This is an archive of the discontinued LLVM Phabricator instance.

Differential D129055

[libc++] Error if someone tries to use MSVC and tell them to contact the libc++ developers
ClosedPublic

Authored by philnik on Jul 3 2022, 6:09 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG64d63f4823af: [libc++] Error if someone tries to use MSVC and tell them to contact the libc++…
Summary

Nobody knows if there are users of libc++ with MSVC. Let's try to find that out and encourage them to upstream their changes to make that configuration work.

Diff Detail

Event Timeline

philnik created this revision.Jul 3 2022, 6:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 6:09 PM
philnik requested review of this revision.Jul 3 2022, 6:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 6:09 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B173479: Diff 441990.Jul 3 2022, 7:39 PM
ldionne accepted this revision.Jul 14 2022, 9:10 AM
This revision is now accepted and ready to land.Jul 14 2022, 9:10 AM
This revision was landed with ongoing or failed builds.Jul 14 2022, 10:35 AM
Closed by commit rG64d63f4823af: [libc++] Error if someone tries to use MSVC and tell them to contact the libc++… (authored by philnik). · Explain Why
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG64d63f4823af: [libc++] Error if someone tries to use MSVC and tell them to contact the libc++….

Revision Contents

PathSize
libcxx/
include/
6 lines

Diff 444722

libcxx/include/__config

Show First 20 Lines • Show All 208 Lines • ▼ Show 20 Lines
# elif defined(_MSC_VER) # elif defined(_MSC_VER)
# define _LIBCPP_COMPILER_MSVC # define _LIBCPP_COMPILER_MSVC
# endif # endif
# if !defined(_LIBCPP_COMPILER_CLANG_BASED) && __cplusplus < 201103L # if !defined(_LIBCPP_COMPILER_CLANG_BASED) && __cplusplus < 201103L
# error "libc++ only supports C++03 with Clang-based compilers. Please enable C++11" # error "libc++ only supports C++03 with Clang-based compilers. Please enable C++11"
# endif # endif
# ifdef _LIBCPP_COMPILER_MSVC
# error If you successfully use libc++ with MSVC please tell the libc++ developers and consider upstreaming your \
changes. We are not aware of anybody using this configuration and know that at least some code is currently broken. \
If there are users of this configuration we are happy to provide support.
# endif
// FIXME: ABI detection should be done via compiler builtin macros. This // FIXME: ABI detection should be done via compiler builtin macros. This
// is just a placeholder until Clang implements such macros. For now assume // is just a placeholder until Clang implements such macros. For now assume
// that Windows compilers pretending to be MSVC++ target the Microsoft ABI, // that Windows compilers pretending to be MSVC++ target the Microsoft ABI,
// and allow the user to explicitly specify the ABI to handle cases where this // and allow the user to explicitly specify the ABI to handle cases where this
// heuristic falls short. // heuristic falls short.
# if defined(_LIBCPP_ABI_FORCE_ITANIUM) && defined(_LIBCPP_ABI_FORCE_MICROSOFT) # if defined(_LIBCPP_ABI_FORCE_ITANIUM) && defined(_LIBCPP_ABI_FORCE_MICROSOFT)
# error "Only one of _LIBCPP_ABI_FORCE_ITANIUM and _LIBCPP_ABI_FORCE_MICROSOFT can be defined" # error "Only one of _LIBCPP_ABI_FORCE_ITANIUM and _LIBCPP_ABI_FORCE_MICROSOFT can be defined"
# elif defined(_LIBCPP_ABI_FORCE_ITANIUM) # elif defined(_LIBCPP_ABI_FORCE_ITANIUM)
▲ Show 20 Lines • Show All 981 Lines • Show Last 20 Lines