address cr

[SchrodingerZhu]

Summary

Signed-off-by: SchrodingerZhu <[e-mail]>

llvm/lib/Analysis/ModuleSummaryAnalysis.cpp

static void computeVariableSummary(ModuleSummaryIndex &Index,
   if (!VTableFuncs.empty())
     GVarSummary->setVTableFuncs(VTableFuncs);
   Index.addGlobalValueSummary(V, std::move(GVarSummary));
 }
 
 static void computeAliasSummary(ModuleSummaryIndex &Index, const GlobalAlias &A,
                                 DenseSet<GlobalValue::GUID> &CantBePromoted) {
   auto *Aliasee = A.getAliaseeObject();
-  // Currently, skip summary for indirect function aliases as
+  // Skip summary for indirect function aliases as
   // summary for aliasee will not be emitted.
-  if (Aliasee->getValueID() != Value::ValueTy::GlobalIFuncVal) {
-    bool NonRenamableLocal = isNonRenamableLocal(A);
-    GlobalValueSummary::GVFlags Flags(
-        A.getLinkage(), A.getVisibility(), NonRenamableLocal,
-        /* Live = */ false, A.isDSOLocal(), A.canBeOmittedFromSymbolTable());
-    auto AS = std::make_unique<AliasSummary>(Flags);
-    auto AliaseeVI = Index.getValueInfo(Aliasee->getGUID());
-    assert(AliaseeVI && "Alias expects aliasee summary to be available");
-    assert(AliaseeVI.getSummaryList().size() == 1 &&
-           "Expected a single entry per aliasee in per-module index");
-    AS->setAliasee(AliaseeVI, AliaseeVI.getSummaryList()[0].get());
-    if (NonRenamableLocal)
-      CantBePromoted.insert(A.getGUID());
-    Index.addGlobalValueSummary(A, std::move(AS));
-  }
-}
+  if (isa<GlobalIFunc>(Aliasee)) {
+    return;
+  }
 
 // Set LiveRoot flag on entries matching the given value name.
 static void setLiveRoot(ModuleSummaryIndex &Index, StringRef Name) {
   if (ValueInfo VI = Index.getValueInfo(GlobalValue::getGUID(Name)))
     for (auto &Summary : VI.getSummaryList())
       Summary->setLive(true);
 }
 

llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

void ModuleBitcodeWriterBase::writePerModuleGlobalValueSummary() {
   // Capture references from GlobalVariable initializers, which are outside
   // of a function scope.
   for (const GlobalVariable &G : M.globals())
     writeModuleLevelReferences(G, NameVals, FSModRefsAbbrev,
                                FSModVTableRefsAbbrev);
 
   for (const GlobalAlias &A : M.aliases()) {
     auto *Aliasee = A.getAliaseeObject();
-    if (!Aliasee->hasName() ||
-        Aliasee->getValueID() == Value::ValueTy::GlobalIFuncVal)
+    if (!Aliasee->hasName() || isa<GlobalIFunc>(Aliasee))
       // IFunc function and Nameless function don't have an entry in the
       // summary, skip it.
       continue;
     auto AliasId = VE.getValueID(&A);
     auto AliaseeId = VE.getValueID(Aliasee);
     NameVals.push_back(AliasId);
     auto *Summary = Index->getGlobalValueSummary(A);
     AliasSummary *AS = cast<AliasSummary>(Summary);