This has been deprecated for a while, since D51714 in 2018.
Remove it in favor of using CMake's find_package() function.
Differential D128777
clang/cmake: Drop use of llvm-config for LLVM install discovery ClosedPublic Authored by Ericson2314 on Jun 28 2022, 6:17 PM.
Details Summary This has been deprecated for a while, since D51714 in 2018. Remove it in favor of using CMake's find_package() function.
Diff Detail
Event Timeline
Comment Actions This is similar to @Ericson2314's change D130735 which also removes llvm-config from LLD. I'm fine with either of the two changes. It might be better to land the Clang and LLD changes separately so they can be reverted separately if needed. This revision is now accepted and ready to land.Aug 3 2022, 11:51 PM Comment Actions @Ericson2314 Your version of these patches removed a few more things than mine (which seems better to me), do you want to just split your patch and commit the parts separately? Closed by commit rGd2b158e29eed: clang/cmake: Drop use of llvm-config for LLVM install discovery (authored by tstellar, committed by Ericson2314). · Explain WhyAug 6 2022, 1:23 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 450566 clang/CMakeLists.txt
|
This doesn't look right (even though it passes my testing). I need to update this part of the patch.