This is an archive of the discontinued LLVM Phabricator instance.

[libTooling] Add a comment about comment parsing to getAssociatedRange.
ClosedPublic

Authored by jacobsa on Jun 28 2022, 5:08 PM.

Details

Summary

It took me multiple hours of debugging plus asking an expert for help to
figure out why this function didn't do what it promised to do. It turns
out there is a flag that needs to be set. Document this, in an attempt
to save the next person the surprise.

Diff Detail

Event Timeline

jacobsa created this revision.Jun 28 2022, 5:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 5:08 PM
jacobsa requested review of this revision.Jun 28 2022, 5:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 5:08 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ymandel accepted this revision.Jun 29 2022, 5:37 AM
ymandel added a subscriber: ymandel.

Thank you!

This revision is now accepted and ready to land.Jun 29 2022, 5:37 AM
ymandel added inline comments.Jun 29 2022, 5:37 AM
clang/include/clang/Tooling/Transformer/SourceCode.h
47
jacobsa updated this revision to Diff 441203.Jun 29 2022, 4:39 PM

Address formatting comment from ymandel.

jacobsa marked an inline comment as done.Jun 29 2022, 4:40 PM

@ymandel: thanks! Are you able to commit?