- User Since
- May 9 2022, 9:31 PM (7 w, 3 d)
Wed, Jun 29
@ymandel: thanks! Are you able to commit?
Address formatting comment from ymandel.
Tue, Jun 28
May 23 2022
May 20 2022
Add [libc++] to the title.
Thanks Eric, PTAL.
Use __is_core_convertible rather than reimplementing it.
May 15 2022
Fix typos pointed out by jloser.
May 14 2022
@philnik sorry if this is an obvious question, but what's the next step here?
Are you able to approve the change so I can commit it, or do you commit
giving me attribution, or what?
May 12 2022
Thanks! You can credit Aaron Jacobs <email@example.com>.
Address latest comments.
May 11 2022
Put "fixes" back into the commit message now that this also handles
FYI, I messed up and submitted the above reply early, sorry. Please take
another look if you're reading by email; I've edited the comment.
Update based on feedback from philnik. Fix __invokable_r instead.
Dumb question: is there a way to see a list of unresolved comments? All I can
see how to do is look at _all_ the comments in the diff view, which is hard
to parse when there are a lot of resolved ones. I'm not 100% sure I addressed
all of your comments.
Update based on comments from philnik.
May 10 2022
@philnik: thanks for the quick review! Sorry if I've made any dumb mistakes
here; this is my first time contributing and I'm not familiar with the style,
processes, or tools.
Address comments from philnik.
Remove the "fixes" part of the description.