Page MenuHomePhabricator

jacobsa (Aaron Jacobs)
User

Projects

User does not belong to any projects.

User Details

User Since
May 9 2022, 9:31 PM (7 w, 3 d)

Recent Activity

Wed, Jun 29

jacobsa added a comment to D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange..

@ymandel: thanks! Are you able to commit?

Wed, Jun 29, 4:40 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange..

Address formatting comment from ymandel.

Wed, Jun 29, 4:39 PM · Restricted Project, Restricted Project

Tue, Jun 28

jacobsa requested review of D128774: [libTooling] Add a comment about comment parsing to getAssociatedRange..
Tue, Jun 28, 5:08 PM · Restricted Project, Restricted Project

May 23 2022

jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

@EricWF @philnik Thanks! But how do I actually commit this? Do you need to do it for me?

May 23 2022, 7:23 PM · Restricted Project, Restricted Project

May 20 2022

jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Add [libc++] to the title.

May 20 2022, 5:47 PM · Restricted Project, Restricted Project
jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Thanks Eric, PTAL.

May 20 2022, 5:14 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Use __is_core_convertible rather than reimplementing it.

May 20 2022, 5:13 PM · Restricted Project, Restricted Project

May 15 2022

jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Fix typos pointed out by jloser.

May 15 2022, 12:09 AM · Restricted Project, Restricted Project

May 14 2022

jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

@philnik sorry if this is an obvious question, but what's the next step here?
Are you able to approve the change so I can commit it, or do you commit
giving me attribution, or what?

May 14 2022, 5:08 PM · Restricted Project, Restricted Project

May 12 2022

jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Thanks! You can credit Aaron Jacobs <jacobsa@google.com>.

May 12 2022, 9:43 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Address latest comments.

May 12 2022, 9:43 PM · Restricted Project, Restricted Project

May 11 2022

jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Put "fixes" back into the commit message now that this also handles
is_nothrow_invocable_r.

May 11 2022, 6:30 PM · Restricted Project, Restricted Project
jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

FYI, I messed up and submitted the above reply early, sorry. Please take
another look if you're reading by email; I've edited the comment.

May 11 2022, 6:29 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Update based on feedback from philnik. Fix __invokable_r instead.

May 11 2022, 6:28 PM · Restricted Project, Restricted Project
jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Dumb question: is there a way to see a list of unresolved comments? All I can
see how to do is look at _all_ the comments in the diff view, which is hard
to parse when there are a lot of resolved ones. I'm not 100% sure I addressed
all of your comments.

I don't know what you are looking at exactly, but on the top right you should see something like 12 / 23 Comments. You can click on that to go to the next unresolved comment. Right next to that you can also select Hide "done" Inlines.

May 11 2022, 6:25 PM · Restricted Project, Restricted Project
jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Dumb question: is there a way to see a list of unresolved comments? All I can
see how to do is look at _all_ the comments in the diff view, which is hard
to parse when there are a lot of resolved ones. I'm not 100% sure I addressed
all of your comments.

May 11 2022, 2:51 AM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Update based on comments from philnik.

May 11 2022, 2:50 AM · Restricted Project, Restricted Project

May 10 2022

jacobsa added a comment to D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

@philnik: thanks for the quick review! Sorry if I've made any dumb mistakes
here; this is my first time contributing and I'm not familiar with the style,
processes, or tools.

May 10 2022, 7:09 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Address comments from philnik.

May 10 2022, 7:08 PM · Restricted Project, Restricted Project
jacobsa updated the diff for D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..

Remove the "fixes" part of the description.

May 10 2022, 3:42 AM · Restricted Project, Restricted Project
jacobsa requested review of D125300: [libc++] type_traits: use __is_core_convertible in __invokable_r..
May 10 2022, 3:38 AM · Restricted Project, Restricted Project