This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add `enableSplitting` and `insertMarkerInOutput` options to `splitAndProcessBuffer`
ClosedPublic

Authored by rriddle on Jun 28 2022, 3:00 PM.

Details

Summary

enableSplitting simply enables/disables whether we should split
or use the full buffer. insertMarkerInOutput toggles if split markers
should be inserted in between prcessed output chunks.

These options allow for merging the duplicate code paths we have
when splitting is optional.

Diff Detail

Event Timeline

rriddle created this revision.Jun 28 2022, 3:00 PM
rriddle requested review of this revision.Jun 28 2022, 3:00 PM
rriddle updated this revision to Diff 440784.Jun 28 2022, 3:02 PM
rriddle edited the summary of this revision. (Show Details)Jun 28 2022, 3:03 PM
rriddle added reviewers: bzcheeseman, lattner.
bzcheeseman accepted this revision.Jun 28 2022, 3:09 PM

Thanks River :)

mlir/lib/Support/ToolUtilities.cpp
91

would this be better done as an llvm::interleave call?

This revision is now accepted and ready to land.Jun 28 2022, 3:09 PM
rriddle added inline comments.Jun 28 2022, 3:11 PM
mlir/lib/Support/ToolUtilities.cpp
91

Yeah, nice suggestion. Let me do that.

lattner accepted this revision.Jun 28 2022, 3:24 PM

nice!!

rriddle updated this revision to Diff 440796.Jun 28 2022, 3:34 PM
rriddle edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jun 28 2022, 3:43 PM
This revision was automatically updated to reflect the committed changes.