Page MenuHomePhabricator

[Driver][test] Add -fuse-ld= option tests for NetBSD
AbandonedPublic

Authored by fcambus on Jun 28 2022, 1:25 PM.

Details

Reviewers
MaskRay

Diff Detail

Event Timeline

fcambus created this revision.Jun 28 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 1:25 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
fcambus requested review of this revision.Jun 28 2022, 1:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2022, 1:25 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming.
The option may be better added in a netbsd specific file.

MaskRay requested changes to this revision.Jun 30 2022, 12:25 PM
This revision now requires changes to proceed.Jun 30 2022, 12:25 PM

I am unsure it is useful to add a test for all OSxfuse_ld_value combinations, especially for an ELF OS like NetBSD which shares many characteristics with other ELF OSes. It will be overwhelming.
The option may be better added in a netbsd specific file.

I noticed there is a fuse-ld-windows.c file with some tests, so would putting NetBSD ones in a new fuse-ld-netbsd.c file make sense?

Either way, I don't have any strong opinion on this. I can also drop the revision if those tests do not seem useful.

fcambus abandoned this revision.Fri, Jul 29, 5:28 AM
MaskRay added a comment.EditedFri, Jul 29, 3:59 PM

Windows is very different from all other OSes. Having a fuse-ld-windows.c may be fine. Again, NetBSD shares many characteristics with other OSes and having a -fuse-ld=lld
test for all ~10 ELF OSes Clang supports seems too much.

Agreed, that makes sense. Sorry for the noise.