Revert clang-tidy fixes for readability-simplify-boolean-expr and add NOLINT

[arjunp]

Summary

The original code is more readable because the goal is to check if the given
value does *not* lie in the range. It is harder to understand this by
reading the rewritten code.

[mehdi_amini]

mlir/lib/Analysis/Presburger/Utils.cpp

123

You haven't changed the expression here?

[mehdi_amini]

LG after you actually revert the line :)

mlir/lib/Analysis/Presburger/Utils.cpp

123

That is, you intended to restore if (!(c >= 0 && c <= divisor - 1)) I think

[arjunp]

Actually revert the change...

[arjunp]

mlir/lib/Analysis/Presburger/Utils.cpp

123

Yes haha, thanks :)

mlir/lib/Analysis/Presburger/Utils.cpp

static LogicalResult getDivRepr(const IntegerRelation &cst, unsigned pos,
   // Due to the form of the upper/lower bound inequalities, the sum of their
   // constants is `divisor - 1 - c`. From this, we can extract c:
   int64_t constantSum = cst.atIneq(lbIneq, cst.getNumCols() - 1) +
                         cst.atIneq(ubIneq, cst.getNumCols() - 1);
   int64_t c = divisor - 1 - constantSum;
 
   // Check if `c` satisfies the condition `0 <= c <= divisor - 1`. This also
   // implictly checks that `divisor` is positive.
-  if (c < 0 || c > divisor - 1)
+  if (!(0 <= c && c <= divisor - 1)) // NOLINT
     return failure();
 
   // The inequality pair can be used to extract the division.
   // Set `expr` to the dividend of the division except the constant term, which
   // is set below.
   expr.resize(cst.getNumCols(), 0);
   for (i = 0, e = cst.getNumVars(); i < e; ++i)
     if (i != pos)