This is an archive of the discontinued LLVM Phabricator instance.

Differential D128654

[MC] Allow annotating custom sections as zerofill
ClosedPublic

Authored by egorzhdan on Jun 27 2022, 8:29 AM.

Details

Reviewers
jroelofs
Commits
rGbe4b40d5bc6c: [MC] Allow annotating custom sections as zerofill
Summary

This is already possible for e.g. cstring_literals, but the entry for zerofill was unnamed.

rdar://90336380

Diff Detail

Event Timeline

egorzhdan created this revision.Jun 27 2022, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 8:29 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
egorzhdan requested review of this revision.Jun 27 2022, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 8:29 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
egorzhdan added a reviewer: jroelofs.Jun 27 2022, 8:30 AM
jroelofs accepted this revision.Jun 27 2022, 8:51 AM

LGTM

This revision is now accepted and ready to land.Jun 27 2022, 8:51 AM
Harbormaster completed remote builds in B172209: Diff 440239.Jun 27 2022, 10:08 AM
This revision was landed with ongoing or failed builds.Jun 28 2022, 7:10 AM
Closed by commit rGbe4b40d5bc6c: [MC] Allow annotating custom sections as zerofill (authored by egorzhdan). · Explain Why
This revision was automatically updated to reflect the committed changes.
egorzhdan added a commit: rGbe4b40d5bc6c: [MC] Allow annotating custom sections as zerofill.

Revision Contents

PathSize
llvm/
lib/
MC/
2 lines
test/
CodeGen/
AArch64/
11 lines

Diff 440611

llvm/lib/MC/MCSectionMachO.cpp

Show All 20 Lines
/// SectionTypeDescriptors - These are strings that describe the various section /// SectionTypeDescriptors - These are strings that describe the various section
/// types. This *must* be kept in order with and stay synchronized with the /// types. This *must* be kept in order with and stay synchronized with the
/// section type list. /// section type list.
static constexpr struct { static constexpr struct {
StringLiteral AssemblerName, EnumName; StringLiteral AssemblerName, EnumName;
} SectionTypeDescriptors[MachO::LAST_KNOWN_SECTION_TYPE + 1] = { } SectionTypeDescriptors[MachO::LAST_KNOWN_SECTION_TYPE + 1] = {
{StringLiteral("regular"), StringLiteral("S_REGULAR")}, // 0x00 {StringLiteral("regular"), StringLiteral("S_REGULAR")}, // 0x00
{StringLiteral(""), StringLiteral("S_ZEROFILL")}, // 0x01 {StringLiteral("zerofill"), StringLiteral("S_ZEROFILL")}, // 0x01
{StringLiteral("cstring_literals"), {StringLiteral("cstring_literals"),
StringLiteral("S_CSTRING_LITERALS")}, // 0x02 StringLiteral("S_CSTRING_LITERALS")}, // 0x02
{StringLiteral("4byte_literals"), {StringLiteral("4byte_literals"),
StringLiteral("S_4BYTE_LITERALS")}, // 0x03 StringLiteral("S_4BYTE_LITERALS")}, // 0x03
{StringLiteral("8byte_literals"), {StringLiteral("8byte_literals"),
StringLiteral("S_8BYTE_LITERALS")}, // 0x04 StringLiteral("S_8BYTE_LITERALS")}, // 0x04
{StringLiteral("literal_pointers"), {StringLiteral("literal_pointers"),
StringLiteral("S_LITERAL_POINTERS")}, // 0x05 StringLiteral("S_LITERAL_POINTERS")}, // 0x05
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines

llvm/test/CodeGen/AArch64/clang-section-macho.ll

;RUN: llc -mtriple=arm64-apple-ios %s -o - | FileCheck %s ;RUN: llc -mtriple=arm64-apple-ios %s -o - | FileCheck %s
define dso_local void @foo() #0 { define dso_local void @foo() #0 {
entry: entry:
ret void ret void
} }
attributes #0 = { "implicit-section-name"="__TEXT,__mytext" } attributes #0 = { "implicit-section-name"="__TEXT,__mytext" }
; CHECK: .section __TEXT,__mytext ; CHECK: .section __TEXT,__mytext
; CHECK-NEXT: .globl _foo ; CHECK-NEXT: .globl _foo
define dso_local void @bar() #1 {
entry:
ret void
}
attributes #1 = { "implicit-section-name"="__EDATA,zerofill" }
; CHECK: .section __EDATA,zerofill
; CHECK-NEXT: .globl _bar