This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Mark more instructions as rematerializable
ClosedPublic

Authored by arsenm on Jun 27 2022, 5:29 AM.

Details

Reviewers
rampitec
Group Reviewers
Restricted Project
Summary

D106023 excluded 16-bit instructions from rematerialization, with the
justification that we can't rematerialize instructions that preserve
the high bits (plus the instructions which do are a confusing mess
between different subtargets). This doesn't make sense to me as a
problem since cases where we would rely on the high bit behavior would
still need to be represented as a register value constraint with a
tied operand. It's not a hidden side effect and should still be
rematerializable.

Diff Detail

Event Timeline

arsenm created this revision.Jun 27 2022, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 5:29 AM
arsenm requested review of this revision.Jun 27 2022, 5:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 5:29 AM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Jun 27 2022, 11:03 AM
This revision is now accepted and ready to land.Jun 27 2022, 11:03 AM