[NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp

[phyBrackets]

Summary

I think that these conditions are unnecessary because in VisitClassTemplateDecl we import the definition via the templated CXXRecordDecl and in VisitVarTemplateDecl via the templated VarDecl. These are named ToTemplted and DTemplated respectively.

[martong]

LGTM

(I don't quite understand the rename and the [LLDB] tag, this is clearly in [Clang][ASTImporter]. Yes, LLDB depends on the ASTImporter).

clang/include/clang/AST/ASTImportError.h

 #ifndef LLVM_CLANG_AST_ASTIMPORTERROR_H
 #define LLVM_CLANG_AST_ASTIMPORTERROR_H
 
 #include "llvm/Support/Error.h"
 
 namespace clang {
 
 class ASTImportError : public llvm::ErrorInfo<ASTImportError> {
-
 public:
   /// \brief Kind of error when importing an AST component.
   enum ErrorKind {
     NameConflict,         /// Naming ambiguity (likely ODR violation).
     UnsupportedConstruct, /// Not supported node or case.
     Unknown               /// Other error.
   };
 

clang/lib/AST/ASTImporter.cpp

if (!ToTemplated->getPreviousDecl()) {
           FoundByLookup->getTemplatedDecl()->getMostRecentDecl();
       if (ToTemplated != PrevTemplated)
         ToTemplated->setPreviousDecl(PrevTemplated);
     }
 
     D2->setPreviousDecl(Recent);
   }
 
-  if (FromTemplated->isCompleteDefinition() &&
-      !ToTemplated->isCompleteDefinition()) {
-    // FIXME: Import definition!
-  }
-
   return D2;
 }
 
 ExpectedDecl ASTNodeImporter::VisitClassTemplateSpecializationDecl(
                                           ClassTemplateSpecializationDecl *D) {
   ClassTemplateDecl *ClassTemplate;
   if (Error Err = importInto(ClassTemplate, D->getSpecializedTemplate()))
     return std::move(Err);
if (!ToTemplated->getPreviousDecl()) {
       auto *PrevTemplated =
           FoundByLookup->getTemplatedDecl()->getMostRecentDecl();
       if (ToTemplated != PrevTemplated)
         ToTemplated->setPreviousDecl(PrevTemplated);
     }
     ToVarTD->setPreviousDecl(Recent);
   }
 
-  if (DTemplated->isThisDeclarationADefinition() &&
-      !ToTemplated->isThisDeclarationADefinition()) {
-    // FIXME: Import definition!
-  }
-
   return ToVarTD;
 }
 
 ExpectedDecl ASTNodeImporter::VisitVarTemplateSpecializationDecl(
     VarTemplateSpecializationDecl *D) {
   // If this record has a definition in the translation unit we're coming from,
   // but this particular declaration is not that definition, import the
   // definition and map to that.