- User Since
- Dec 5 2021, 11:05 AM (67 w, 5 d)
Mon, Mar 20
Thu, Mar 9
Wed, Mar 8
Wed, Mar 1
Thanks @Mordante !
Hey @Mordante , Sorry for it! I'm not sure how to close it manually, I tried Add Action here but I cannot see any option for Closing the revision ?
Thanks @Mordante , updated!
Hey @ldionne, Here is the follow up revision https://reviews.llvm.org/D145087
https://github.com/llvm/llvm-project/commit/813e1da9749a5d2d604198cf534f750c842eda22 , commited by me only!
Hey @philnik , I'm not sure about, can we land this now?
Mon, Feb 27
Sun, Feb 26
Feb 17 2023
Jan 31 2023
for ignoring the whitespace changes used git diff -b that's why it's failing for now but will change it once you review the basic structure of the patch
Hey @philnik , sorry for the format changes but this is what i can do best for now , not sure about the removing all the format changes!
For an update on the patch, this patch is currently for _LIBCPP_STD_VER > 20 , and tests cases fixed accordingly to pass the CI , if there is anything that needs to be change, let me know!
Jan 22 2023
Jan 18 2023
Jan 15 2023
It still failing on the ranges.min.max.pass.cpp, we need to guard that too for passing the CI. Or Is there any other work around?
Correctly places the macros.
Nov 10 2022
Hey @EricWF , could you please take a look at this patch, i guess there are some tests which got affected by this . I'm not sure if i need to update them for passing the CI?
Nov 8 2022
update the revision with few changes for the correct version
Nov 7 2022
Nov 5 2022
rebase the changes on top of main
Oct 21 2022
Oct 20 2022
Hey @ldionne Thanks for quick response, I'd squash it here https://reviews.llvm.org/D136356 .
Hey @philnik , could you please review this patch instead of the previous one?
Oct 19 2022
Updating the patch after rebasing
Re-uploading the patch
Oct 5 2022
Hey @philnik , could you tell me about the tests? does changes in the type.pass.cpp looks correct? Although I tried running the test using llvm-lit but got the failure on iterator_concept_conformance.compile.pass.cpp and type.pass.cpp.
I'm not sure about, where to look for testing of it or need to create new tests ?
Jul 4 2022
Jun 26 2022
Jun 14 2022
May 11 2022
May 10 2022
May 6 2022
May 5 2022
Rebase several commits
is there still any problem ? I'm not sure ?
address the buildbot failing issue
Correct the number of character in line 1
address inline comment