This is an archive of the discontinued LLVM Phabricator instance.

Differential D128566

GlobalISel: Make LoadStoreOpt preserve all
ClosedPublic

Authored by arsenm on Jun 24 2022, 4:40 PM.

Details

Reviewers
aemerson
paquette
Summary

Avoids dropping CSE info analysis

Diff Detail

Event Timeline

arsenm created this revision.Jun 24 2022, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 4:40 PM
Herald added subscribers: hiraditya, rovka. · View Herald Transcript
arsenm requested review of this revision.Jun 24 2022, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 4:40 PM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B171976: Diff 439922.Jun 24 2022, 5:29 PM
paquette accepted this revision.Jun 24 2022, 10:10 PM

LGTM

This revision is now accepted and ready to land.Jun 24 2022, 10:10 PM
arsenm closed this revision.Jun 25 2022, 6:42 AM

e7bc73739a00e471cb96527415e6819cebfc7e80

Revision Contents

PathSize
llvm/
lib/
CodeGen/
GlobalISel/
1 line
test/
CodeGen/
AArch64/
GlobalISel/
3 lines

Diff 439922

llvm/lib/CodeGen/GlobalISel/LoadStoreOpt.cpp

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Linesvoid LoadStoreOpt::init(MachineFunction &MF) {
Builder.setMF(MF); Builder.setMF(MF);
IsPreLegalizer = !MF.getProperties().hasProperty( IsPreLegalizer = !MF.getProperties().hasProperty(
MachineFunctionProperties::Property::Legalized); MachineFunctionProperties::Property::Legalized);
InstsToErase.clear(); InstsToErase.clear();
} }
void LoadStoreOpt::getAnalysisUsage(AnalysisUsage &AU) const { void LoadStoreOpt::getAnalysisUsage(AnalysisUsage &AU) const {
AU.addRequired<AAResultsWrapperPass>(); AU.addRequired<AAResultsWrapperPass>();
AU.setPreservesAll();
getSelectionDAGFallbackAnalysisUsage(AU); getSelectionDAGFallbackAnalysisUsage(AU);
MachineFunctionPass::getAnalysisUsage(AU); MachineFunctionPass::getAnalysisUsage(AU);
} }
BaseIndexOffset GISelAddressing::getPointerInfo(Register Ptr, BaseIndexOffset GISelAddressing::getPointerInfo(Register Ptr,
MachineRegisterInfo &MRI) { MachineRegisterInfo &MRI) {
BaseIndexOffset Info; BaseIndexOffset Info;
Register PtrAddRHS; Register PtrAddRHS;
▲ Show 20 Lines • Show All 591 Lines • Show Last 20 Lines

llvm/test/CodeGen/AArch64/GlobalISel/gisel-commandline-option.ll

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
; VERIFY-NEXT: Verify generated machine code ; VERIFY-NEXT: Verify generated machine code
; ENABLED-NEXT: Analysis for ComputingKnownBits ; ENABLED-NEXT: Analysis for ComputingKnownBits
; ENABLED-O1-NEXT: MachineDominator Tree Construction ; ENABLED-O1-NEXT: MachineDominator Tree Construction
; ENABLED-O1-NEXT: Analysis containing CSE Info ; ENABLED-O1-NEXT: Analysis containing CSE Info
; ENABLED-O1-NEXT: PreLegalizerCombiner ; ENABLED-O1-NEXT: PreLegalizerCombiner
; VERIFY-O0-NEXT: AArch64O0PreLegalizerCombiner ; VERIFY-O0-NEXT: AArch64O0PreLegalizerCombiner
; VERIFY-NEXT: Verify generated machine code ; VERIFY-NEXT: Verify generated machine code
; ENABLED-O1-NEXT: Basic Alias Analysis (stateless AA impl) ; ENABLED-O1-NEXT: Basic Alias Analysis (stateless AA impl)
; ENABLED-O1-NEXT: Function Alias Analysis Results ; ENABLED-O1-NEXT: Function Alias Analysis Results
; ENABLED-O1-NEXT: LoadStoreOpt ; ENABLED-O1-NEXT: LoadStoreOpt
; ENABLED-O1-NEXT: Analysis containing CSE Info
; VERIFY-O0-NEXT: Analysis containing CSE Info ; VERIFY-O0-NEXT: Analysis containing CSE Info
; ENABLED-NEXT: Legalizer ; ENABLED-NEXT: Legalizer
; VERIFY-NEXT: Verify generated machine code ; VERIFY-NEXT: Verify generated machine code
; ENABLED: RegBankSelect ; ENABLED: RegBankSelect
; VERIFY-NEXT: Verify generated machine code ; VERIFY-NEXT: Verify generated machine code
; ENABLED-NEXT: Localizer ; ENABLED-NEXT: Localizer
; VERIFY-O0-NEXT: Verify generated machine code ; VERIFY-O0-NEXT: Verify generated machine code
; ENABLED-NEXT: Analysis for ComputingKnownBits ; ENABLED-NEXT: Analysis for ComputingKnownBits
Show All 18 Lines