Page MenuHomePhabricator

[Sanitizers] Fix malloc_usable_size interceptions signatures for FreeBSD
AbandonedPublic

Authored by devnexen on Jun 24 2022, 3:01 PM.

Details

Reviewers
phosek
vitalybuka

Diff Detail

Event Timeline

devnexen created this revision.Jun 24 2022, 3:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 3:01 PM
devnexen requested review of this revision.Jun 24 2022, 3:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 3:01 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka added inline comments.Jun 24 2022, 3:07 PM
compiler-rt/lib/asan/asan_malloc_linux.cpp
120

why this makes a difference?

devnexen added inline comments.Jun 24 2022, 3:11 PM
compiler-rt/lib/asan/asan_malloc_linux.cpp
120

oh just matching freebsd's signature.

vitalybuka accepted this revision.Jun 24 2022, 4:24 PM

Maybe then just keep as is to avoid new preprocessor branches?

This revision is now accepted and ready to land.Jun 24 2022, 4:24 PM
devnexen abandoned this revision.Sat, Jan 21, 12:48 PM

This patch is unneeded. If the ABI matches (which ignores const), the difference has no impact to the generated code.