This is an archive of the discontinued LLVM Phabricator instance.

[Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD
ClosedPublic

Authored by fcambus on Jun 24 2022, 3:09 AM.

Details

Summary

This was requested in D109244.

It needs D109051 to be applied for the OpenBSD driver to generate the correct library names, otherwise we always get libcompiler_rt.a.

Diff Detail

Event Timeline

fcambus created this revision.Jun 24 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 3:09 AM
fcambus requested review of this revision.Jun 24 2022, 3:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2022, 3:09 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay added inline comments.Jun 24 2022, 11:14 AM
clang/test/Driver/coverage-ld.c
52

Don't add //\n by cargo cult. It's not a recommended style (Having blank lines helps { } in Vim like editors)

54

Note: the new recommended libclang_rt* hierarchy is LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on. This matches LLVM_ENABLE_RUNTIMES='compiler-rt;libcxx;libcxxabi;libunwind'.

OpenBSD hasn't switched, though.

With the new hierarchy, the location may look like: lib/x86_64-unknown-openbsd/libclang_rt.profile.a

MaskRay accepted this revision.Jun 24 2022, 11:14 AM
This revision is now accepted and ready to land.Jun 24 2022, 11:14 AM
MaskRay retitled this revision from [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD. to [Driver][test] Add libclang_rt.profile{{.*}}.a tests for OpenBSD.Jun 24 2022, 11:14 AM
This revision was landed with ongoing or failed builds.Jun 26 2022, 1:19 PM
This revision was automatically updated to reflect the committed changes.