This is an archive of the discontinued LLVM Phabricator instance.

[clang] missing outer template levels when checking template constraints
Needs ReviewPublic

Authored by Lancern on Jun 22 2022, 8:56 AM.

Details

Summary

When checking constraint satisfaction on template arguments, the outer
template levels are not added to MultiLevelTemplateArgumentList.

Fix bugs https://github.com/llvm/llvm-project/issues/50845

Diff Detail

Event Timeline

Lancern created this revision.Jun 22 2022, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2022, 8:56 AM
Lancern requested review of this revision.Jun 22 2022, 8:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2022, 8:56 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Lancern edited reviewers, added: klimek, dcoughlin, rsmith; removed: Richard, smith.Jun 22 2022, 9:06 AM
Lancern updated this revision to Diff 439253.Jun 22 2022, 8:27 PM

Fix some regression issues

So I don't think this is the right fix for this... But I DID check and see that the test case seems to be fixed here: https://reviews.llvm.org/D126907 , which does a lot of rework for this sort of thing.

That patch is expected to be complete/ready for submission in the 'near future', but I'm still working through 1 more issue.