This is an archive of the discontinued LLVM Phabricator instance.

Differential D128136

[libc++][clang-format] Change the penalties to prefer a newline over breaking after parens
AbandonedPublic

Authored by philnik on Jun 19 2022, 2:15 AM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

philnik created this revision.Jun 19 2022, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2022, 2:15 AM
philnik requested review of this revision.Jun 19 2022, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2022, 2:15 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik updated this revision to Diff 438185.Jun 19 2022, 2:16 AM

Rebased

Harbormaster completed remote builds in B170717: Diff 438185.Jun 19 2022, 2:17 AM
philnik updated this revision to Diff 438186.Jun 19 2022, 2:17 AM
  • Fix patch
Harbormaster completed remote builds in B170718: Diff 438186.Jun 19 2022, 2:18 AM
philnik updated this revision to Diff 438188.Jun 19 2022, 2:46 AM
  • Increase BreakOpenParnethesis penalty
Harbormaster completed remote builds in B170720: Diff 438188.Jun 19 2022, 2:47 AM
ldionne requested changes to this revision.EditedJun 21 2022, 8:16 AM

Can you explain what the difference is? Preferably in the commit message.

This revision now requires changes to proceed.Jun 21 2022, 8:16 AM
philnik abandoned this revision.Jul 29 2022, 6:01 AM

Revision Contents

PathSize
libcxx/
4 lines
include/
15 lines

Diff 438185

libcxx/.clang-format

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines
IndentWrappedFunctionNames: false IndentWrappedFunctionNames: false
IndentRequires: true IndentRequires: true
InsertTrailingCommas: Wrapped InsertTrailingCommas: Wrapped
KeepEmptyLinesAtTheStartOfBlocks: false KeepEmptyLinesAtTheStartOfBlocks: false
MaxEmptyLinesToKeep: 1 MaxEmptyLinesToKeep: 1
NamespaceIndentation: Inner NamespaceIndentation: Inner
PackConstructorInitializers: NextLine PackConstructorInitializers: NextLine
PenaltyIndentedWhitespace: 61 PenaltyIndentedWhitespace: 1
PenaltyBreakOpenParenthesis: 60
PenaltyReturnTypeOnItsOwnLine: 10
Language: Cpp Language: Cpp
Standard: c++20 Standard: c++20
SpacesInAngles: Leave SpacesInAngles: Leave
AlwaysBreakTemplateDeclarations: true AlwaysBreakTemplateDeclarations: true
PointerAlignment: Left PointerAlignment: Left
Show All 10 Lines

libcxx/include/string

Show First 20 Lines • Show All 533 Lines • ▼ Show 20 Lines
#include <__memory/allocate_at_least.h> #include <__memory/allocate_at_least.h>
#include <__string/char_traits.h> #include <__string/char_traits.h>
#include <__string/extern_template_lists.h> #include <__string/extern_template_lists.h>
#include <__utility/auto_cast.h> #include <__utility/auto_cast.h>
#include <__utility/move.h> #include <__utility/move.h>
#include <__utility/swap.h> #include <__utility/swap.h>
#include <__utility/unreachable.h> #include <__utility/unreachable.h>
#include <climits> #include <climits>
#include <compare>
#include <cstdint> #include <cstdint>
#include <cstdio> // EOF #include <cstdio> // EOF
#include <cstdlib> #include <cstdlib>
#include <cstring> #include <cstring>
#include <initializer_list>
#include <iosfwd> #include <iosfwd>
#include <limits> #include <limits>
#include <memory> #include <memory>
#include <stdexcept> #include <stdexcept>
#include <string_view> #include <string_view>
#include <type_traits> #include <type_traits>
#include <version> #include <version>
#ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS #ifndef _LIBCPP_HAS_NO_WIDE_CHARACTERS
# include <cwchar> # include <cwchar>
#endif #endif
// standard-mandated includes
// [iterator.range]
#include <__iterator/access.h>
#include <__iterator/data.h>
#include <__iterator/empty.h>
#include <__iterator/reverse_access.h>
#include <__iterator/size.h>
// [string.syn]
#include <compare>
#include <initializer_list>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 4,121 Lines • Show Last 20 Lines