This is an archive of the discontinued LLVM Phabricator instance.

Differential D128136

[libc++][clang-format] Change the penalties to prefer a newline over breaking after parens
AbandonedPublic

Authored by philnik on Jun 19 2022, 2:15 AM.

Download Raw Diff

Details

Reviewers

ldionne
Mordante
var-const

Group Reviewers

Restricted Project

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

philnik created this revision.Jun 19 2022, 2:15 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2022, 2:15 AM

philnik requested review of this revision.Jun 19 2022, 2:15 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2022, 2:15 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Rebased

Harbormaster completed remote builds in B170717: Diff 438185.Jun 19 2022, 2:17 AM

Fix patch

Harbormaster completed remote builds in B170718: Diff 438186.Jun 19 2022, 2:18 AM

Increase BreakOpenParnethesis penalty

Harbormaster completed remote builds in B170720: Diff 438188.Jun 19 2022, 2:47 AM

Can you explain what the difference is? Preferably in the commit message.

This revision now requires changes to proceed.Jun 21 2022, 8:16 AM

philnik abandoned this revision.Jul 29 2022, 6:01 AM

Revision Contents

Path

Size

libcxx/

4 lines

Diff 438188

libcxx/.clang-format

	Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines
	IndentWrappedFunctionNames: false			IndentWrappedFunctionNames: false
	IndentRequires: true			IndentRequires: true
	InsertTrailingCommas: Wrapped			InsertTrailingCommas: Wrapped
	KeepEmptyLinesAtTheStartOfBlocks: false			KeepEmptyLinesAtTheStartOfBlocks: false
	MaxEmptyLinesToKeep: 1			MaxEmptyLinesToKeep: 1
	NamespaceIndentation: Inner			NamespaceIndentation: Inner
	PackConstructorInitializers: NextLine			PackConstructorInitializers: NextLine

	PenaltyIndentedWhitespace: 61			PenaltyIndentedWhitespace: 1
				PenaltyBreakOpenParenthesis: 300
				PenaltyReturnTypeOnItsOwnLine: 10

	Language: Cpp			Language: Cpp
	Standard: c++20			Standard: c++20
	SpacesInAngles: Leave			SpacesInAngles: Leave

	AlwaysBreakTemplateDeclarations: true			AlwaysBreakTemplateDeclarations: true
	PointerAlignment: Left			PointerAlignment: Left

	Show All 10 Lines