This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Don't lower CALL to CALL_NOP on LV2 (PS3)
AbandonedPublic

Authored by ProtoByter on Jun 16 2022, 3:00 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This change stops LLVM from lowering PPCISD::CALL to PPCISD::CALL_NOP on LV2 since it stops it from being able to build LV2 code
I've tested this with RPCS3 using a sample from PSL1GHT and I can confirm that it runs for me
This fixes issue #55456

Diff Detail

Event Timeline

ProtoByter created this revision.Jun 16 2022, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 3:00 AM
ProtoByter requested review of this revision.Jun 16 2022, 3:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2022, 3:00 AM
ProtoByter retitled this revision from [PowerPC] Don't lower to CALL to CALL_NOP on LV2 (PS3) to [PowerPC] Don't lower CALL to CALL_NOP on LV2 (PS3).Jun 16 2022, 3:35 AM
ProtoByter abandoned this revision.Jun 16 2022, 3:46 AM

Turns out that this fix will only work when there aren't multiple TOCs so it's not very useful, I have a feeling that the issue lies deeper in the backend, like in the tablegen files, however I'm not very experienced so I don't completely know what I'm doing :(