This is an archive of the discontinued LLVM Phabricator instance.

[libc] Add a status page for math functions.
ClosedPublic

Authored by lntue on Jun 15 2022, 4:58 PM.

Details

Summary

Add a status page for math functions.

Diff Detail

Event Timeline

lntue created this revision.Jun 15 2022, 4:58 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 15 2022, 4:58 PM
lntue requested review of this revision.Jun 15 2022, 4:58 PM
lntue updated this revision to Diff 437543.Jun 16 2022, 7:52 AM

Remove redundant line in performance table.

sivachandra added inline comments.Jun 16 2022, 9:06 AM
libc/docs/math.rst
26

I think you want to say,

By default, we will aim to be correctly rounded for all rounding modes. The current rounding mode of the floating point environment is used to perform computations and produce the final result.

You probably don't need to list the different rounding modes below.

229

The MPFR or the GNU C library are not referenced in the text. Why list them here? Perhaps you want to add a section about testing and talk about MPFR there.

sivachandra accepted this revision.Jun 16 2022, 9:07 AM
This revision is now accepted and ready to land.Jun 16 2022, 9:07 AM
lntue updated this revision to Diff 437708.Jun 16 2022, 2:35 PM

Address comments.

lntue updated this revision to Diff 437709.Jun 16 2022, 2:37 PM
lntue marked an inline comment as done.

Add link to C rounding modes.

lntue added inline comments.Jun 16 2022, 2:39 PM
libc/docs/math.rst
229

I added the reference to use MPFR for correctness testing and GNU C library for performance reference.

This revision was landed with ongoing or failed builds.Jun 16 2022, 2:42 PM
This revision was automatically updated to reflect the committed changes.