[mlir][python] Actually set UseLocalScope printing flag

[mabrowning]

Summary

The useLocalScope printing flag has been passed around between pybind methods, but doesn't actually enable the corresponding printing flag.

[stellaraccident]

Thanks - good catch. Do you have commit access to land?

[mabrowning]

In D127907#3587153, @stellaraccident wrote:

Thanks - good catch. Do you have commit access to land?

I don't think so, this is my first contribution.

[stellaraccident]

Thanks for the contribution. I'll land it at my next opportunity, then.

[mabrowning]

In D127907#3587189, @stellaraccident wrote:

Thanks for the contribution. I'll land it at my next opportunity, then.

Sorry, looks like I need to rebase my patch; I had taken it from a slightly version of our internal copy of the repo. The operation.py test slightly changes.

[mabrowning]

"rebased" onto latest main, updated test due to conflict.

mlir/lib/Bindings/Python/IRCore.cpp

void PyOperationBase::print(py::object fileObject, bool binary,
 
   MlirOpPrintingFlags flags = mlirOpPrintingFlagsCreate();
   if (largeElementsLimit)
     mlirOpPrintingFlagsElideLargeElementsAttrs(flags, *largeElementsLimit);
   if (enableDebugInfo)
     mlirOpPrintingFlagsEnableDebugInfo(flags, /*prettyForm=*/prettyDebugInfo);
   if (printGenericOpForm)
     mlirOpPrintingFlagsPrintGenericOpForm(flags);
+  if (useLocalScope)
+    mlirOpPrintingFlagsUseLocalScope(flags);
 
   PyFileAccumulator accum(fileObject, binary);
   mlirOperationPrintWithFlags(operation, flags, accum.getCallback(),
                               accum.getUserData());
   mlirOpPrintingFlagsDestroy(flags);
 }
 
 py::object PyOperationBase::getAsm(bool binary,

mlir/test/python/ir/operation.py

 
 # CHECK-LABEL: TEST: testOperationPrint
 @run
 def testOperationPrint():
   ctx = Context()
   module = Module.parse(
       r"""
     func.func @f1(%arg0: i32) -> i32 {
-      %0 = arith.constant dense<[1, 2, 3, 4]> : tensor<4xi32>
+      %0 = arith.constant dense<[1, 2, 3, 4]> : tensor<4xi32> loc("nom")
       return %arg0 : i32
     }
   """, ctx)
 
   # Test print to stdout.
   # CHECK: return %arg0 : i32
   module.operation.print()
 
def testOperationPrint():
   f = io.BytesIO()
   # CHECK: <class 'bytes'>
   # CHECK: return %arg0 : i32
   module.operation.print(file=f, binary=True)
   bytes_value = f.getvalue()
   print(bytes_value.__class__)
   print(bytes_value)
 
+  # Test get_asm local_scope.
+  # CHECK: constant dense<[1, 2, 3, 4]> : tensor<4xi32> loc("nom")
+  module.operation.print(enable_debug_info=True, use_local_scope=True)
+
   # Test get_asm with options.
   # CHECK: value = opaque<"elided_large_const", "0xDEADBEEF"> : tensor<4xi32>
   # CHECK: "func.return"(%arg0) : (i32) -> () -:4:7
   module.operation.print(
       large_elements_limit=2,
       enable_debug_info=True,
       pretty_debug_info=True,
       print_generic_op_form=True,