This is an archive of the discontinued LLVM Phabricator instance.

Differential D127882

[lldb/Fuzzer] Create ninja target for target fuzzer
ClosedPublic

Authored by cassanova on Jun 15 2022, 10:59 AM.

Details

Reviewers
JDevlieghere
mib
Commits
rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer
Summary

Create a ninja target for running the LLDB target fuzzer.

Diff Detail

Event Timeline

cassanova created this revision.Jun 15 2022, 10:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2022, 10:59 AM
Herald added subscribers: Michael137, mgorny. · View Herald Transcript
cassanova requested review of this revision.Jun 15 2022, 10:59 AM
Herald added a subscriber: lldb-commits. · View Herald TranscriptJun 15 2022, 10:59 AM
Harbormaster completed remote builds in B170053: Diff 437251.Jun 15 2022, 11:02 AM
JDevlieghere added a comment.Jun 15 2022, 11:07 AM

Can this go into lldb-target-fuzzer/CMakeLists.txt?

cassanova added a comment.Jun 15 2022, 11:31 AM

Yes it can, updating the diff to reflect that.

cassanova updated this revision to Diff 437266.Jun 15 2022, 11:32 AM

Moved changes to lldb-target-fuzzer/CMakeLists.txt file

Harbormaster completed remote builds in B170064: Diff 437266.Jun 15 2022, 11:33 AM
mib added a comment.Jun 15 2022, 11:37 AM

How is this any different from running ninja lldb-target-fuzzer ? I might be missing something ...

mib added a comment.Jun 15 2022, 11:42 AM
In D127882#3586516, @mib wrote:

How is this any different from running ninja lldb-target-fuzzer ? I might be missing something ...

Never mind, I assumed lldb-target-fuzzer would not only build the fuzzer but also run it

mib accepted this revision.Jun 15 2022, 11:45 AM

LGTM!

This revision is now accepted and ready to land.Jun 15 2022, 11:45 AM
This revision was landed with ongoing or failed builds.Jun 15 2022, 11:55 AM
Closed by commit rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer (authored by cassanova). · Explain Why
This revision was automatically updated to reflect the committed changes.
cassanova added a commit: rGf3250da1b94f: [lldb/Fuzzer] Create ninja target for target fuzzer.
stella.stamenova added a reverting change: rGb10579d0b519: Revert "[lldb/Fuzzer] Create ninja target for target fuzzer".Jun 15 2022, 12:41 PM
stella.stamenova mentioned this in D125943: [trace][intelpt] Support system-wide tracing [11] - Read warnings and perf conversion in the client.Jun 15 2022, 1:24 PM
JDevlieghere added a comment.Jun 15 2022, 2:10 PM

This needs to be moved into the if(TARGET lldb-target-fuzzer) clause.

Revision Contents

PathSize
lldb/
tools/
lldb-fuzzer/
lldb-target-fuzzer/
6 lines

Diff 437277

lldb/tools/lldb-fuzzer/lldb-target-fuzzer/CMakeLists.txt

Show All 9 Lines
if(TARGET lldb-target-fuzzer) if(TARGET lldb-target-fuzzer)
target_include_directories(lldb-target-fuzzer PRIVATE ..) target_include_directories(lldb-target-fuzzer PRIVATE ..)
target_link_libraries(lldb-target-fuzzer target_link_libraries(lldb-target-fuzzer
PRIVATE PRIVATE
liblldb liblldb
lldbFuzzerUtils lldbFuzzerUtils
) )
endif() endif()
add_custom_target(fuzz-lldb-target
COMMENT "Running the LLDB target fuzzer..."
COMMAND cd ${CMAKE_CURRENT_SOURCE_DIR} && $<TARGET_FILE:lldb-target-fuzzer>
USES_TERMINAL
)