This is an archive of the discontinued LLVM Phabricator instance.

[inliner] Add per-SCC-pass InlineAdvisor printing option
ClosedPublic

Authored by Northbadge on Jun 13 2022, 1:23 PM.

Details

Summary

Adds option to print the contents of the Inline Advisor after each SCC Inliner pass

Diff Detail

Event Timeline

Northbadge created this revision.Jun 13 2022, 1:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 1:23 PM
Northbadge requested review of this revision.Jun 13 2022, 1:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 1:23 PM

overall lgtm, some nits. Also, for the commit message, it's not that the "advisor prints", rather, that we have a way to print at SCC level - if you can rephrase.

Can you also add a test?

llvm/lib/Transforms/IPO/Inliner.cpp
109

nit: EnablePostSCCAdvisorPrinting / enable-scc-inline-advisor-printing

...just to hint to the reader what the relation with the other printing is.

Resolve comments and added tests.

Northbadge retitled this revision from [inliner] Add per-SCC Inline Advisor printing option to [inliner] Add per-SCC-pass InlineAdvisor printing option.Jun 13 2022, 2:35 PM
Northbadge edited the summary of this revision. (Show Details)
mtrofin accepted this revision.Jun 13 2022, 2:45 PM

lgtm, just please move the ml one down into test/Transforms/Inline/ML

llvm/test/Transforms/Inline/enable-inline-advisor-printing-ml.ll
1

this should go under the ML subfolder there.

This revision is now accepted and ready to land.Jun 13 2022, 2:45 PM
Northbadge marked an inline comment as done.

Added one more test case.

Moved ML test

This revision was landed with ongoing or failed builds.Jun 14 2022, 8:07 AM
This revision was automatically updated to reflect the committed changes.