Page MenuHomePhabricator
Differential D127678

[libc++] Implement parts of P1413R3 (Deprecate std::aligned_storage and std::aligned_union)
Needs ReviewPublic
Actions

Authored by philnik on Jun 13 2022, 11:37 AM.

Details

Reviewers
ldionne
Mordante
var-const
Group Reviewers
Restricted Project
Summary

The aliases aren't marked deprecated currently because there is no way to do that AFAIK.

Diff Detail

Unit TestsFailed
View All

TimeTest
670 mslibcxx CI C++11 > llvm-libc++-shared-cfg-in.std/experimental/memory/memory_polymorphic_allocator_class/memory_polymorphic_allocator_mem::allocate.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/allocate.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++11 -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/allocate.pass.cpp.dir/t.tmp.exe
690 mslibcxx CI C++11 > llvm-libc++-shared-cfg-in.std/experimental/memory/memory_polymorphic_allocator_class/memory_polymorphic_allocator_mem::deallocate.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/deallocate.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++11 -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/188d9c5b1f00-1/llvm-project/libcxx-ci/build/generic-cxx11/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/Output/deallocate.pass.cpp.dir/t.tmp.exe
6,920 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 12'; clang-tidy /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings
3,300 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::double_include.sh.cpp
Script: -- : 'RUN: at line 11'; /usr/bin/c++ -c /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/libcxx/double_include.sh.cpp -o /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/test/libcxx/Output/double_include.sh.cpp.dir/t.tmp.first.o --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings
3,290 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::min_max_macros.compile.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/c++ /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/libcxx/min_max_macros.compile.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/6a4c17cad617-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -fsyntax-only
View Full Test Results (914 Failed)

Event Timeline

philnik created this revision.Jun 13 2022, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:37 AM
philnik requested review of this revision.Jun 13 2022, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 11:37 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante added inline comments.Jun 13 2022, 12:07 PM
libcxx/docs/Status/Cxx2bPapers.csv
45

Since it's not possible to deprecated using I would consider this complete, but let's keep the note for clarity.

libcxx/include/type_traits
161

Please update the synopsis.

Harbormaster completed remote builds in B169517: Diff 436495.Jun 13 2022, 1:14 PM

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
5 lines
2 lines
include/
6 lines
8 lines
test/
std/
experimental/
memory/
memory.polymorphic.allocator.class/
memory.polymorphic.allocator.mem/
4 lines
2 lines
utilities/
meta/
meta.trans/
meta.trans.other/
14 lines
2 lines
14 lines

Diff 436495

View Options

libcxx/docs/Status/Cxx2b.rst

Loading...
View Options

libcxx/docs/Status/Cxx2bPapers.csv

Loading...
View Options

libcxx/include/__config

Loading...
View Options

libcxx/include/type_traits

Loading...
View Options

libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/allocate.pass.cpp

Loading...
View Options

libcxx/test/std/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/deallocate.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.depr.verify.cpp

Loading...
View Options

libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_union.depr.verify.cpp

Loading...