This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add GCC12 CI job
AbandonedPublic

Authored by philnik on Jun 13 2022, 1:56 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

philnik created this revision.Jun 13 2022, 1:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 1:56 AM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik requested review of this revision.Jun 13 2022, 1:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2022, 1:56 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 436371.Jun 13 2022, 6:25 AM
  • Disable format tests and enable implicit_deduction_guides.pass.cpp for GCC 12
ldionne added inline comments.Jun 13 2022, 8:25 AM
libcxx/utils/ci/run-buildbot
302–303

We should actually switch to GCC 12 instead of adding a new job. We only support the latest-released GCC per our policy. We should also update https://libcxx.llvm.org/#platform-and-compiler-support to say that we support GCC 12 only.

philnik added inline comments.Jun 13 2022, 8:30 AM
libcxx/utils/ci/run-buildbot
302–303

Wouldn't that mean that we only support clang 14 and 15? I thought the logic was "the latest compiler at the time of the last release branch".

@philnik I'm a bit puzzled by this review. How does this differ from D126667?

philnik abandoned this revision.Jun 13 2022, 10:05 AM

@philnik I'm a bit puzzled by this review. How does this differ from D126667?

Sorry, I completely forgot that you already worked on that.

No problem, I just was a bit confused; I thought these were comments to my patch ;-)