Page MenuHomePhabricator

[PS4/PS5][profiling] Go back to the old way of doing a runtime hook
ClosedPublic

Authored by probinson on Jun 10 2022, 9:18 AM.

Details

Summary

Profiling stopped working for us after D98061, which was largely a
Fuschia-specific patch but in one place used isOSBinFormatELF to
make a decision. I'm adding a PS4/PS5 exception to that, so we can
get profiling to work again.

I'm pretty sure isOSBinFormatELF isn't really the right predicate,
but I'm not familiar enough with this area to say what is.

Diff Detail

Event Timeline

probinson created this revision.Jun 10 2022, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 9:18 AM
probinson requested review of this revision.Jun 10 2022, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 10 2022, 9:18 AM
phosek accepted this revision.Jun 16 2022, 1:03 AM

I'm pretty sure isOSBinFormatELF isn't really the right predicate,
but I'm not familiar enough with this area to say what is.

I believe this is dependent on the binary format and the linker but I don't think we have any mechanism to check the linker version here.

This revision is now accepted and ready to land.Jun 16 2022, 1:03 AM
This revision was landed with ongoing or failed builds.Jun 16 2022, 11:37 AM
This revision was automatically updated to reflect the committed changes.