[clang-format][NFC] Remove unused FormatStyle members

[curdeius]

Good finding!

[MyDeveloperDay]

If we remove it from here, then it will get removed from the documentation

Also if you remove it, then the ClangFormatStyleOptions.rst needs to be regenerated. But somehow I think we need that comment no? incase someone is looking up their legacy options when migrating?

[owenpan]

In D127390#3575628, @MyDeveloperDay wrote:

If we remove it from here, then it will get removed from the documentation

Also if you remove it, then the ClangFormatStyleOptions.rst needs to be regenerated.

Good catch! I will regenerate it.

But somehow I think we need that comment no? incase someone is looking up their legacy options when migrating?

IIRC there were other deprecated options that were removed from Format.h. These two options were old enough and IMO we left them in Format.h long enough. Nevertheless, I will see if we can add the comments back without keeping the FormatStyle members.

[owenpan]

See D127578.

clang/include/clang/Format/Format.h

struct FormatStyle {
   ///   callFunction(a,
   ///                b,
   ///                c,
   ///                d);
   /// \endcode
   /// \version 9
   bool AllowAllArgumentsOnNextLine;
 
-  /// This option is **deprecated**. See ``NextLine`` of
-  /// ``PackConstructorInitializers``.
-  /// \version 9
-  bool AllowAllConstructorInitializersOnNextLine;
-
   /// If the function declaration doesn't fit on a line,
   /// allow putting all parameters of a function declaration onto
   /// the next line even if ``BinPackParameters`` is ``false``.
   /// \code
   ///   true:
   ///   void myFunction(
   ///       int a, int b, int c, int d, int e);
   ///

   /// \code
   ///   namespace Foo { namespace Bar {
   ///   namespace Extra {
   ///   }}}
   /// \endcode
   /// \version 5
   bool CompactNamespaces;
 
-  /// This option is **deprecated**. See ``CurrentLine`` of
-  /// ``PackConstructorInitializers``.
-  /// \version 3.7
-  bool ConstructorInitializerAllOnOneLineOrOnePerLine;
-
   /// The number of characters to use for indentation of constructor
   /// initializer lists as well as inheritance lists.
   /// \version 3.7
   unsigned ConstructorInitializerIndentWidth;
 
   /// Indent width for line continuations.
   /// \code
   ///    ContinuationIndentWidth: 2