This is an archive of the discontinued LLVM Phabricator instance.

[EarlyCSE] Update tests to use opaque pointers (NFC)
ClosedPublic

Authored by nikic on Jun 8 2022, 2:40 AM.

Details

Reviewers
aeubanks
Group Reviewers
Restricted Project
Commits
rG3c514d31d791: [EarlyCSE] Update tests to use opaque pointers (NFC)
Summary

Update the EarlyCSE tests to use opaque pointers. Mainly putting this up for review to get confirmation that it's fine to start migrating tests.

Worth noting that this leaves some bitcast ptr to ptr instructions in the input IR behind which are no longer necessary. This is because these use numbered instructions, so it's hard to drop these in an automated fashion (as it would require renumbering all other instructions as well). I'm leaving that as a problem for another day.

The test updates have been performed using https://gist.github.com/nikic/98357b71fd67756b0f064c9517b62a34.

Diff Detail

Event Timeline

nikic created this revision.Jun 8 2022, 2:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 2:40 AM
nikic requested review of this revision.Jun 8 2022, 2:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2022, 2:40 AM
aeubanks accepted this revision.Jun 9 2022, 8:50 AM
aeubanks added a subscriber: aeubanks.

can you link the command/script in the description?

This revision is now accepted and ready to land.Jun 9 2022, 8:50 AM
nikic edited the summary of this revision. (Show Details)Jun 9 2022, 11:45 AM
This revision was landed with ongoing or failed builds.Jun 10 2022, 12:54 AM
This revision was automatically updated to reflect the committed changes.