This is an archive of the discontinued LLVM Phabricator instance.

Add some documentation for the "breakpoint name" feature
AcceptedPublic

Authored by jingham on Jun 3 2022, 5:12 PM.

Details

Summary

breakpoint names have a bunch of uses, some obvious and some not so (to anyone who was not me...) so it seemed worthwhile to add some documentation. I hung it off the "breakpoint name" command - that's the natural place to look when you are browsing the command set.

This seems clear to me, but it would be useful to know if it is so to others, or how to make it so...

Diff Detail

Event Timeline

jingham created this revision.Jun 3 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 5:12 PM
jingham requested review of this revision.Jun 3 2022, 5:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 3 2022, 5:12 PM
mib added a comment.Jun 3 2022, 5:37 PM

Thanks for writing that! I'm sure many users will find it very useful.

lldb/source/Commands/CommandObjectBreakpoint.cpp
2088

Can we add some kind of quoting (backticks maybe) to this ?

2099–2102

Does it mean that giving a breakpoint a name will hide it by default to the list,delete,disable commands ?

2103–2106

This sentences is already very long. I'd either surround to delete or disable ALL breakpoints between commas or rephrase it like this.

jingham updated this revision to Diff 434222.Jun 3 2022, 6:02 PM

Address review comments.

Mostly reworking the paragraph on breakpoint hiding.

lldb/source/Commands/CommandObjectBreakpoint.cpp
2088

I don't think we use backticks anywhere in the help, but that should have quotes.

2099–2102

Not sure what you are asking. These options are all off by default, so if you add a name that doesn't have the --allow-list, --allow-delete or --allow-disable explicitly configured, it won't affect how the breakpoint shows up. But if you do configure these to true, the indeed, the breakpoint won't show up.

IDE's often want to use some breakpoints for their own purposes, and it's annoying when a user does "break delete" and then messes up their IDE because they deleted breakpoints it was relying on. This is a mechanism to protect those breakpoints, but it is purely opt in.

2103–2106

That was a little contorted. I rewrote it to be clearer, see what you think.

kastiglione accepted this revision.Jun 10 2022, 9:46 AM

thank you again

This revision is now accepted and ready to land.Jun 10 2022, 9:46 AM
mib accepted this revision.Jun 10 2022, 10:05 AM

Thanks Jim!