[flang] Add RUN lines using `fir-opt`

[awarzynski]

Summary

In tests that define a pass pipeline to use, add a RUN line using fir-opt.

(extracted from https://reviews.llvm.org/D126890)

[clementval]

Why not having two run lines since tco is still here?

[awarzynski]

In D126955#3563064, @clementval wrote:

Why not having two run lines since tco is still here?

No strong opinion. I'd like to say "less is more", but then I'm adding more RUN lines in https://reviews.llvm.org/D126890. I think that as long as we have multiple tools capable of performing a particular task, this is going to be a bit contentious.

What's your preference? If we keep tco then I'd like to add flang-new too. To me, these tests exercise a particular pass and that's what fir-opt (and mlir-opt and opt) are designed for.

[clementval]

In D126955#3563265, @awarzynski wrote:

In D126955#3563064, @clementval wrote:

Why not having two run lines since tco is still here?

No strong opinion. I'd like to say "less is more", but then I'm adding more RUN lines in https://reviews.llvm.org/D126890. I think that as long as we have multiple tools capable of performing a particular task, this is going to be a bit contentious.

What's your preference? If we keep tco then I'd like to add flang-new too. To me, these tests exercise a particular pass and that's what fir-opt (and mlir-opt and opt) are designed for.

I would prefer to keep the tco lines if tco is here so it is still tested. When(/if) it is remnoved we can remove the run lines.

[awarzynski]

Restore tco RUN lines

[rovka]

Thanks, this LGTM but I'll let @clementval have the final word :)

[clementval]

LGTM

flang/test/Fir/global-initialization.fir

+// RUN: fir-opt --fir-to-llvm-ir %s | FileCheck %s
 // RUN: tco --fir-to-llvm-ir %s | FileCheck %s
 
 fir.global internal @_QEmask : !fir.array<32xi32> {
   %c0_i32 = arith.constant 1 : i32
   %0 = fir.undefined !fir.array<32xi32>
   %2 = fir.insert_on_range %0, %c0_i32 from (0) to (31) : (!fir.array<32xi32>, i32) -> !fir.array<32xi32>
   fir.has_value %2 : !fir.array<32xi32>
 }

flang/test/Fir/rebox-susbtring.fir

 // Test translation to llvm IR of fir.rebox with substring array sections.
 
+// RUN: fir-opt -o - -cg-rewrite --fir-to-llvm-ir -cse %s | FileCheck %s
 // RUN: tco -o - -cg-rewrite --fir-to-llvm-ir -cse %s | FileCheck %s
 
 // Test a fir.rebox with a substring on a character array with constant
 // length (like c(:)(2:*) where c is a fir.box array with constant length).
 
 // CHECK-LABEL: llvm.func @char_section(
 // CHECK-SAME:                          %[[VAL_0:.*]]: !llvm.ptr<[[char20_descriptor_t:.*]]>)>>) {
 func.func @char_section(%arg0: !fir.box<!fir.array<?x!fir.char<1,20>>>) {