This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][Docs] Update for HowToSetUpLLVMStyleRTTI.rst, NFC.
ClosedPublic

Authored by bzcheeseman on Jun 2 2022, 9:58 PM.

Details

Summary

This patch updates the document with some advanced use cases and examples on how to set up and use LLVM-style RTTI. It includes a few motivating examples to get readers comfortable with the concepts.

Diff Detail

Event Timeline

bzcheeseman created this revision.Jun 2 2022, 9:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 9:58 PM
bzcheeseman requested review of this revision.Jun 2 2022, 9:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 9:58 PM
lattner accepted this revision.Jun 2 2022, 10:03 PM

nice, thank you! You might want to ping llvm weekly about this, casting.h is pretty widely used

llvm/docs/HowToSetUpLLVMStyleRTTI.rst
546

backticks around llvm::Optional?

This revision is now accepted and ready to land.Jun 2 2022, 10:03 PM
bzcheeseman marked an inline comment as done.Jun 2 2022, 10:26 PM
This revision was landed with ongoing or failed builds.Jun 2 2022, 10:34 PM
This revision was automatically updated to reflect the committed changes.

This is a major doc update. My observation is that if you get a quick approval, it may be worth waiting a bit in case others may suggest some items.