LLVM LIT tests for our upcoming dot product lowering change
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks for the patch. For the title, it's quite common for LLVM patches to use [PassName] prefix, so for this one [LowerMatrixIntrinsics].
llvm/test/Transforms/LowerMatrixIntrinsics/dot-product.ll | ||
---|---|---|
6 | it might be good to also throw in a test with inputs that don't take up a full register, like <3 x float>, maybe also <1 x float> |
Comment Actions
LGTM! If you think it's valuable, you could also add a TN test ((Nx1)^T * Nx1) in case we end up optimizing that in the future, but up to you.
it might be good to also throw in a test with inputs that don't take up a full register, like <3 x float>, maybe also <1 x float>