This is an archive of the discontinued LLVM Phabricator instance.

[LowerMatrixIntrinsics] Add dot product tests
ClosedPublic

Authored by virnarula on Jun 2 2022, 9:03 PM.

Details

Summary

LLVM LIT tests for our upcoming dot product lowering change

Diff Detail

Event Timeline

virnarula created this revision.Jun 2 2022, 9:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 9:03 PM
virnarula requested review of this revision.Jun 2 2022, 9:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2022, 9:03 PM
virnarula edited the summary of this revision. (Show Details)Jun 2 2022, 9:09 PM
virnarula added reviewers: fhahn, anemet, thegameg.
fhahn added a comment.Jun 3 2022, 1:25 AM

Thanks for the patch. For the title, it's quite common for LLVM patches to use [PassName] prefix, so for this one [LowerMatrixIntrinsics].

llvm/test/Transforms/LowerMatrixIntrinsics/dot-product.ll
6

it might be good to also throw in a test with inputs that don't take up a full register, like <3 x float>, maybe also <1 x float>

virnarula retitled this revision from [llvm-lib] Add dot product tests to [LowerMatrixIntrinsics] Add dot product tests.Jun 3 2022, 9:02 AM
virnarula updated this revision to Diff 434052.Jun 3 2022, 9:59 AM

Adding tests for smaller dimensions

fhahn accepted this revision.Jun 3 2022, 11:52 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jun 3 2022, 11:52 AM
thegameg accepted this revision.Jun 3 2022, 12:01 PM

LGTM! If you think it's valuable, you could also add a TN test ((Nx1)^T * Nx1) in case we end up optimizing that in the future, but up to you.

This revision was automatically updated to reflect the committed changes.