This is an archive of the discontinued LLVM Phabricator instance.

Differential D126671

cmake: fix clang standalone build
ClosedPublic

Authored by mizvekov on May 30 2022, 11:36 AM.

Details

Reviewers
nikic
Ericson2314
Commits
rG93319128d0d4: cmake: fix clang standalone build
Summary

D126308 broke building clang standalone, as LLVM_UTILS_INSTALL_DIR is
not exported.

Signed-off-by: Matheus Izvekov <mizvekov@gmail.com>

Diff Detail

Event Timeline

mizvekov created this revision.May 30 2022, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2022, 11:36 AM
Herald added a subscriber: mgorny. · View Herald Transcript
mizvekov requested review of this revision.May 30 2022, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2022, 11:36 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mizvekov added reviewers: nikic, Ericson2314.May 30 2022, 11:37 AM
mizvekov mentioned this in D126308: cmake: use llvm dir variables for clang/utils/hmaptool.
Harbormaster completed remote builds in B166952: Diff 432966.May 30 2022, 12:06 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 30 2022, 12:56 PM
Closed by commit rG93319128d0d4: cmake: fix clang standalone build (authored by mizvekov). · Explain Why
This revision was automatically updated to reflect the committed changes.
mizvekov added a commit: rG93319128d0d4: cmake: fix clang standalone build.

Revision Contents

PathSize
clang/
utils/
hmaptool/
2 lines

Diff 432966

clang/utils/hmaptool/CMakeLists.txt

add_custom_command(OUTPUT "${LLVM_TOOLS_BINARY_DIR}/hmaptool" add_custom_command(OUTPUT "${LLVM_TOOLS_BINARY_DIR}/hmaptool"
COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool" "${LLVM_TOOLS_BINARY_DIR}" COMMAND "${CMAKE_COMMAND}" -E copy "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool" "${LLVM_TOOLS_BINARY_DIR}"
DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool") DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/hmaptool")
install(PROGRAMS hmaptool DESTINATION "${LLVM_UTILS_INSTALL_DIR}" COMPONENT hmaptool) install(PROGRAMS hmaptool DESTINATION "${LLVM_TOOLS_INSTALL_DIR}" COMPONENT hmaptool)
add_custom_target(hmaptool ALL DEPENDS "${LLVM_TOOLS_BINARY_DIR}/hmaptool") add_custom_target(hmaptool ALL DEPENDS "${LLVM_TOOLS_BINARY_DIR}/hmaptool")
set_target_properties(hmaptool PROPERTIES FOLDER "Utils") set_target_properties(hmaptool PROPERTIES FOLDER "Utils")
if(NOT LLVM_ENABLE_IDE) if(NOT LLVM_ENABLE_IDE)
add_llvm_install_targets("install-hmaptool" add_llvm_install_targets("install-hmaptool"
DEPENDS hmaptool DEPENDS hmaptool
COMPONENT hmaptool) COMPONENT hmaptool)
endif() endif()