This is an archive of the discontinued LLVM Phabricator instance.

Differential D126577

[Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered
ClosedPublic

Authored by wrotki on May 27 2022, 4:28 PM.

Details

Reviewers
rsundahl
yln
thetruestblue
delcypher
Commits
rGe2adffc39c52: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered
Summary

Previous couple commits replaced SANITIZER_MAC with SANITIZER_APPLE in bulk.
This change will prompt anyone still trying to use SANITIZER_MAC to rename.

Diff Detail

Event Timeline

wrotki created this revision.May 27 2022, 4:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 4:28 PM
wrotki requested review of this revision.May 27 2022, 4:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 4:28 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B166728: Diff 432666.May 27 2022, 4:45 PM
yln accepted this revision.May 31 2022, 10:09 AM
This revision is now accepted and ready to land.May 31 2022, 10:09 AM
Herald added a subscriber: Enna1. · View Herald TranscriptMay 31 2022, 10:09 AM
This revision was landed with ongoing or failed builds.May 31 2022, 6:09 PM
Closed by commit rGe2adffc39c52: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered (authored by wrotki). · Explain Why
This revision was automatically updated to reflect the committed changes.
wrotki added a commit: rGe2adffc39c52: [Sanitizers][Darwin] Deprecate SANITIZER_MAC - fail compilation if encountered.
wrotki mentioned this in D129502: [Sanitizers][Darwin] Remove SANITIZER_MAC.Jul 11 2022, 10:26 AM
wrotki mentioned this in rGaf0a26b47661: [Sanitizers][Darwin] Remove SANITIZER_MAC.Jul 12 2022, 9:11 AM

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
6 lines

Diff 433258

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
// - SANITIZER_IOS: devices (iOS and iOS-like) // - SANITIZER_IOS: devices (iOS and iOS-like)
// - SANITIZER_WATCHOS // - SANITIZER_WATCHOS
// - SANITIZER_TVOS // - SANITIZER_TVOS
// - SANITIZER_IOSSIM: simulators (iOS and iOS-like) // - SANITIZER_IOSSIM: simulators (iOS and iOS-like)
// - SANITIZER_DRIVERKIT // - SANITIZER_DRIVERKIT
#if defined(__APPLE__) #if defined(__APPLE__)
# define SANITIZER_APPLE 1 # define SANITIZER_APPLE 1
// SANITIZER_MAC will be deprecated/removed in the future // SANITIZER_MAC will be deprecated/removed in the future
# define SANITIZER_MAC SANITIZER_APPLE # define SANITIZER_MAC \
error "SANITIZER_MAC will be removed, please use SANITIZER_APPLE"
# include <TargetConditionals.h> # include <TargetConditionals.h>
# if TARGET_OS_OSX # if TARGET_OS_OSX
# define SANITIZER_OSX 1 # define SANITIZER_OSX 1
# else # else
# define SANITIZER_OSX 0 # define SANITIZER_OSX 0
# endif # endif
# if TARGET_OS_IPHONE # if TARGET_OS_IPHONE
# define SANITIZER_IOS 1 # define SANITIZER_IOS 1
Show All 17 Lines
# endif # endif
# if TARGET_OS_DRIVERKIT # if TARGET_OS_DRIVERKIT
# define SANITIZER_DRIVERKIT 1 # define SANITIZER_DRIVERKIT 1
# else # else
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
# endif # endif
#else #else
# define SANITIZER_APPLE 0 # define SANITIZER_APPLE 0
# define SANITIZER_MAC SANITIZER_APPLE # define SANITIZER_MAC \
error "SANITIZER_MAC will be removed, please use SANITIZER_APPLE"
# define SANITIZER_OSX 0 # define SANITIZER_OSX 0
# define SANITIZER_IOS 0 # define SANITIZER_IOS 0
# define SANITIZER_WATCHOS 0 # define SANITIZER_WATCHOS 0
# define SANITIZER_TVOS 0 # define SANITIZER_TVOS 0
# define SANITIZER_IOSSIM 0 # define SANITIZER_IOSSIM 0
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
#endif #endif
▲ Show 20 Lines • Show All 335 Lines • Show Last 20 Lines