This is an archive of the discontinued LLVM Phabricator instance.

[bazel] BLAKE3: Adopt aarch64 and x86_64.
ClosedPublic

Authored by chapuni on May 27 2022, 7:47 AM.

Details

Summary

FIXME: arm(32) may be applicable here. I haven't tested yet.

Diff Detail

Event Timeline

chapuni created this revision.May 27 2022, 7:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 7:47 AM
chapuni requested review of this revision.May 27 2022, 7:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 27 2022, 7:47 AM
MaskRay accepted this revision.May 27 2022, 11:50 AM

Looks great!

% cd utils/bazel
% bazel build --config=generic_clang @llvm-project//llvm:Support --copt=-w

I can find sse and avx .o files in bazel-out/k8-fastbuild/bin/external/llvm-project/llvm/libSupport.so-2.params.

utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
205

https://docs.bazel.build/versions/main/configurable-attributes.html#the-default-condition there should be a //conditions:default condition for non-aarch64-nonx86_64 CPUs.

This revision is now accepted and ready to land.May 27 2022, 11:50 AM
chapuni marked an inline comment as done.May 27 2022, 3:04 PM
chapuni added inline comments.
utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
205

I misunderstood to expect noop w/o default and I have confirmed default:[] is essential here. Thanks!

This revision was landed with ongoing or failed builds.May 27 2022, 3:06 PM
This revision was automatically updated to reflect the committed changes.
chapuni marked an inline comment as done.