This is an archive of the discontinued LLVM Phabricator instance.

[NFC][JumpThreading] Remove InsertFreezeWhenUnfoldingSelect pass parameter
ClosedPublic

Authored by aeubanks on May 26 2022, 2:19 PM.

Details

Summary

All callers pass true.

select-unfold-freeze.ll is now a subset of select.ll so delete it.

Diff Detail

Event Timeline

aeubanks created this revision.May 26 2022, 2:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 2:19 PM
aeubanks requested review of this revision.May 26 2022, 2:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2022, 2:19 PM
nikic added a comment.May 26 2022, 2:28 PM

Dropping the freeze option is fine, but I'm not sure about the threshold. It looks like it was added for out-of-tree users? https://github.com/llvm/llvm-project/commit/d120916ca732ca0d7639a0e60ce5f246b77e711d Don't know if still relevant.

llvm/test/Transforms/JumpThreading/select-unfold-freeze.ll
0

Can you check whether this test is the same as select-unfold.ll now and delete if so?

aeubanks updated this revision to Diff 432388.May 26 2022, 2:37 PM

drop test, keep threshold parameter

aeubanks retitled this revision from [NFC][JumpThreading] Remove jump thread pass parameters to [NFC][JumpThreading] Remove InsertFreezeWhenUnfoldingSelect pass parameter.May 26 2022, 2:37 PM
aeubanks edited the summary of this revision. (Show Details)
nikic accepted this revision.May 26 2022, 3:02 PM

LGTM

This revision is now accepted and ready to land.May 26 2022, 3:02 PM
This revision was landed with ongoing or failed builds.May 26 2022, 4:13 PM
This revision was automatically updated to reflect the committed changes.