This is an archive of the discontinued LLVM Phabricator instance.

Differential D126325

[libc++][test] Verify std::ranges::rbegin, crbegin, rend, crend are CPOs
ClosedPublic

Authored by jloser on May 24 2022, 1:43 PM.

Details

Reviewers
var-const
ldionne
Mordante
philnik
Group Reviewers
Restricted Project
Commits
rG5a2dbe49bedc: [libc++][test] Verify std::ranges::rbegin, crbegin, rend, crend are CPOs
Summary

Uncomment the tests to ensure std::ranges::rbegin and friends are indeed
customization points objects.

Diff Detail

Event Timeline

jloser created this revision.May 24 2022, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 1:43 PM
jloser requested review of this revision.May 24 2022, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 1:43 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.May 24 2022, 1:46 PM

LGTM assuming CI passes.

This revision is now accepted and ready to land.May 24 2022, 1:46 PM
Harbormaster completed remote builds in B166131: Diff 431780.May 24 2022, 4:55 PM
var-const accepted this revision.May 24 2022, 7:04 PM
Closed by commit rG5a2dbe49bedc: [libc++][test] Verify std::ranges::rbegin, crbegin, rend, crend are CPOs (authored by • joe_loser). · Explain WhyMay 25 2022, 7:51 AM
This revision was automatically updated to reflect the committed changes.
• joe_loser added a commit: rG5a2dbe49bedc: [libc++][test] Verify std::ranges::rbegin, crbegin, rend, crend are CPOs.

Revision Contents

PathSize
libcxx/
test/
std/
library/
description/
conventions/
customization.point.object/
8 lines

Diff 431994

libcxx/test/std/library/description/conventions/customization.point.object/cpo.compile.pass.cpp

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
static_assert(test(std::compare_weak_order_fallback, 1, 2)); static_assert(test(std::compare_weak_order_fallback, 1, 2));
// [range.access] // [range.access]
static_assert(test(std::ranges::begin, a)); static_assert(test(std::ranges::begin, a));
static_assert(test(std::ranges::end, a)); static_assert(test(std::ranges::end, a));
static_assert(test(std::ranges::cbegin, a)); static_assert(test(std::ranges::cbegin, a));
static_assert(test(std::ranges::cdata, a)); static_assert(test(std::ranges::cdata, a));
static_assert(test(std::ranges::cend, a)); static_assert(test(std::ranges::cend, a));
//static_assert(test(std::ranges::crbegin, a)); static_assert(test(std::ranges::crbegin, a));
//static_assert(test(std::ranges::crend, a)); static_assert(test(std::ranges::crend, a));
static_assert(test(std::ranges::data, a)); static_assert(test(std::ranges::data, a));
static_assert(test(std::ranges::empty, a)); static_assert(test(std::ranges::empty, a));
//static_assert(test(std::ranges::rbegin, a)); static_assert(test(std::ranges::rbegin, a));
//static_assert(test(std::ranges::rend, a)); static_assert(test(std::ranges::rend, a));
static_assert(test(std::ranges::size, a)); static_assert(test(std::ranges::size, a));
static_assert(test(std::ranges::ssize, a)); static_assert(test(std::ranges::ssize, a));
// [range.factories] // [range.factories]
// views::empty<T> is not a CPO // views::empty<T> is not a CPO
static_assert(test(std::views::iota, 1)); static_assert(test(std::views::iota, 1));
static_assert(test(std::views::iota, 1, 10)); static_assert(test(std::views::iota, 1, 10));
//static_assert(test(std::views::istream<int>, 1); //static_assert(test(std::views::istream<int>, 1);
Show All 17 Lines