This is an archive of the discontinued LLVM Phabricator instance.

Differential D126290

[TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend.
ClosedPublic

Authored by kosarev on May 24 2022, 4:22 AM.

Download Raw Diff

Details

Reviewers

Paul-C-Anagnostopoulos

Commits

rG046f90173567: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	60,060 ms	x64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

kosarev created this revision.May 24 2022, 4:22 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 4:22 AM

kosarev requested review of this revision.May 24 2022, 4:22 AM

Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2022, 4:22 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

A follow-up from https://reviews.llvm.org/D85838#inline-1209632.

kosarev added a reviewer: Paul-C-Anagnostopoulos.May 24 2022, 4:23 AM

kosarev mentioned this in D85838: New TableGen Programmer's Reference document.

foad added a subscriber: foad.May 24 2022, 4:34 AM

foad added inline comments.

llvm/docs/TableGen/ProgRef.rst
212	"distinguish"

Fixed spelling.

llvm/docs/TableGen/ProgRef.rst
212	Seems to be a common mistake. :-) Thanks!

Harbormaster completed remote builds in B166032: Diff 431645.May 24 2022, 5:51 AM

Looks good to me.

So can this be submitted or we need a formal approval from someone else?

I think my approval is sufficient.

This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 7:16 AM

This revision was landed with ongoing or failed builds.

Closed by commit rG046f90173567: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend. (authored by kosarev). · Explain Why

This revision was automatically updated to reflect the committed changes.

kosarev added a commit: rG046f90173567: [TableGen] Undeprecate 'field' when used with the CodeEmitterGen backend..

Revision Contents

Path

Size

llvm/

docs/

TableGen/

4 lines

Diff 431645

llvm/docs/TableGen/ProgRef.rst

	Show First 20 Lines • Show All 202 Lines • ▼ Show 20 Lines		identifiers::

	assert bit bits class code			assert bit bits class code
	dag def else false foreach			dag def else false foreach
	defm defset defvar field if			defm defset defvar field if
	in include int let list			in include int let list
	multiclass string then true			multiclass string then true

	.. warning::			.. warning::
	The ``field`` reserved word is deprecated.			The ``field`` reserved word is deprecated, except when used with the
				CodeEmitterGen backend where it's used to distinguish normal record
				foadUnsubmitted Not Done Reply Inline Actions "distinguish" foad: "distinguish"
				kosarevAuthorUnsubmitted Done Reply Inline Actions Seems to be a common mistake. :-) Thanks! kosarev: Seems to be a common mistake. :-) Thanks!
				fields from encoding fields.

	Bang operators			Bang operators
	--------------			--------------

	TableGen provides "bang operators" that have a wide variety of uses:			TableGen provides "bang operators" that have a wide variety of uses:

	.. productionlist::			.. productionlist::
	BangOperator: one of			BangOperator: one of
	▲ Show 20 Lines • Show All 1,791 Lines • Show Last 20 Lines