This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Fix Tensor_InsertSliceOp description
ClosedPublic

Authored by logan on May 23 2022, 6:12 PM.

Details

Summary

This commit fixes Tensor_InsertSliceOp size inputs/attributes description. Before this commit, the description says the size inputs/attributes denote the size of the return type.

But according to InsertSliceOpConstantArgumentFolder in lib/Dialect/Tensor/IR/TensorOps.cpp, the size inputs/attributes actually denote the size of the source type. After some off-line discussion with the author of TensorOps.td and TensorOps.cpp, it is a typo in the Op description.

This commit updates the Op description to match the actual usage.

Diff Detail

Event Timeline

logan created this revision.May 23 2022, 6:12 PM
logan requested review of this revision.May 23 2022, 6:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 6:12 PM
logan edited the summary of this revision. (Show Details)May 23 2022, 6:13 PM
This revision is now accepted and ready to land.May 24 2022, 10:09 PM
This revision was automatically updated to reflect the committed changes.