This is an archive of the discontinued LLVM Phabricator instance.

[TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array.
ClosedPublic

Authored by chapuni on May 21 2022, 5:18 PM.

Details

Summary

Fixup for https://reviews.llvm.org/D73044
String literal has an implicit terminator '\0'. This commit adjusts char array
to long literal.

This causes difference of artifacts between -long-string-literals=true
and false.

Diff Detail

Event Timeline

chapuni created this revision.May 21 2022, 5:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 5:18 PM
chapuni requested review of this revision.May 21 2022, 5:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 5:18 PM

I will rebase this after D126135 will be applied.

rnk accepted this revision.May 23 2022, 10:19 AM

lgtm

This revision is now accepted and ready to land.May 23 2022, 10:19 AM
This revision was landed with ongoing or failed builds.May 23 2022, 2:25 PM
This revision was automatically updated to reflect the committed changes.