This is an archive of the discontinued LLVM Phabricator instance.

Differential D126135

emitStringLiteralDef: Return earlier here. NFC.
ClosedPublic

Authored by chapuni on May 21 2022, 5:15 PM.

Details

Reviewers
ldrumm
rnk
Commits
rG40b9a2616e45: emitStringLiteralDef: Return earlier here. NFC.

Diff Detail

Event Timeline

chapuni created this revision.May 21 2022, 5:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 5:15 PM
chapuni requested review of this revision.May 21 2022, 5:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2022, 5:15 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
chapuni added a reviewer: ldrumm.May 21 2022, 5:16 PM
chapuni mentioned this in D126136: [TableGen] emitStringLiteralDef: Pad trailing '\0' at the end of char array..May 21 2022, 5:21 PM
Harbormaster completed remote builds in B165694: Diff 431187.May 21 2022, 6:07 PM
rnk accepted this revision.May 23 2022, 10:19 AM
rnk added a subscriber: rnk.

lgtm

This revision is now accepted and ready to land.May 23 2022, 10:19 AM
This revision was landed with ongoing or failed builds.May 23 2022, 2:03 PM
Closed by commit rG40b9a2616e45: emitStringLiteralDef: Return earlier here. NFC. (authored by chapuni). · Explain Why
This revision was automatically updated to reflect the committed changes.
chapuni added a commit: rG40b9a2616e45: emitStringLiteralDef: Return earlier here. NFC..

Revision Contents

PathSize
llvm/
utils/
TableGen/
14 lines

Diff 431476

llvm/utils/TableGen/SequenceToOffsetTable.h

Show First 20 Lines • Show All 164 Lines • ▼ Show 20 Linespublic:
} }
/// `emitStringLiteralDef` - Print out the table as the body of an array /// `emitStringLiteralDef` - Print out the table as the body of an array
/// initializer, where each element is a C string literal terminated by /// initializer, where each element is a C string literal terminated by
/// `\0`. Falls back to emitting a comma-separated integer list if /// `\0`. Falls back to emitting a comma-separated integer list if
/// `EmitLongStrLiterals` is false /// `EmitLongStrLiterals` is false
void emitStringLiteralDef(raw_ostream &OS, const llvm::Twine &Decl) const { void emitStringLiteralDef(raw_ostream &OS, const llvm::Twine &Decl) const {
assert(Entries && "Call layout() before emitStringLiteralDef()"); assert(Entries && "Call layout() before emitStringLiteralDef()");
if (EmitLongStrLiterals) { if (!EmitLongStrLiterals) {
OS << "\n#ifdef __GNUC__\n"
<< "#pragma GCC diagnostic push\n"
<< "#pragma GCC diagnostic ignored \"-Woverlength-strings\"\n"
<< "#endif\n"
<< Decl << " = {\n";
} else {
OS << Decl << " = {\n"; OS << Decl << " = {\n";
emit(OS, printChar, "0"); emit(OS, printChar, "0");
OS << "\n};\n\n"; OS << "\n};\n\n";
return; return;
} }
OS << "\n#ifdef __GNUC__\n"
<< "#pragma GCC diagnostic push\n"
<< "#pragma GCC diagnostic ignored \"-Woverlength-strings\"\n"
<< "#endif\n"
<< Decl << " = {\n";
for (auto I : Seqs) { for (auto I : Seqs) {
OS << " /* " << I.second << " */ \""; OS << " /* " << I.second << " */ \"";
for (auto C : I.first) { for (auto C : I.first) {
printStrLitEscChar(OS, C); printStrLitEscChar(OS, C);
} }
OS << "\\0\"\n"; OS << "\\0\"\n";
} }
OS << "};\n" OS << "};\n"
Show All 27 Lines