[count] Use correct integral type

[gAlfonso-bit]

Summary

This was done by making the types consistent with each other, and returning an unsigned long instead of a long int.

[MaskRay]

Where is the undefined behavior? size_t is unsigned long long on 32-bit ELF platforms. You need %zu.

[gAlfonso-bit]

Updated @MaskRay

[MaskRay]

[NFC]

There is a difference so this is not NFC.

[gAlfonso-bit]

This comment was removed by gAlfonso-bit.

[MaskRay]

In D126121#3975459, @gAlfonso-bit wrote:

Ok, but it works the same even if the generated asm is different. Plus, I do not have commit perms, so you can use [e-mail] as the committer email address @MaskRay

Thanks for the email address. Do you have a preferred name used in git commit --amend --author='name <email>'?

[gAlfonso-bit]

This comment was removed by gAlfonso-bit.

llvm/utils/count/count.c

 /*===- count.c - The 'count' testing tool ---------------------------------===*\
  *
  * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
  * See https://llvm.org/LICENSE.txt for license information.
  * SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
  *
 \*===----------------------------------------------------------------------===*/
 
 #include <stdlib.h>
 #include <stdio.h>
 
 int main(int argc, char **argv) {
-  unsigned Count, NumLines, NumRead;
+  size_t Count, NumLines, NumRead;
   char Buffer[4096], *End;
 
   if (argc != 2) {
     fprintf(stderr, "usage: %s <expected line count>\n", argv[0]);
     return 2;
   }
 
-  Count = strtol(argv[1], &End, 10);
+  Count = strtoul(argv[1], &End, 10);
   if (*End != '\0' && End != argv[1]) {
     fprintf(stderr, "%s: invalid count argument '%s'\n", argv[0], argv[1]);
     return 2;
   }
 
   NumLines = 0;
   do {
-    unsigned i;
+    size_t i;
 
     NumRead = fread(Buffer, 1, sizeof(Buffer), stdin);
 
     for (i = 0; i != NumRead; ++i)
       if (Buffer[i] == '\n')
         ++NumLines;
   } while (NumRead == sizeof(Buffer));
     
   if (!feof(stdin)) {
     fprintf(stderr, "%s: error reading stdin\n", argv[0]);
     return 3;
   }
 
   if (Count != NumLines) {
-    fprintf(stderr, "Expected %d lines, got %d.\n", Count, NumLines);
+    fprintf(stderr, "Expected %zu lines, got %zu.\n", Count, NumLines);
     return 1;
   }
 
   return 0;
 }