This is an archive of the discontinued LLVM Phabricator instance.

[Polly] Migrate -polly-mse to the new pass manager.
ClosedPublic

Authored by YangKeao on May 18 2022, 3:23 AM.

Details

Summary

This patch implements the MaximalStaticExpansion and its printer in NPM.

Diff Detail

Event Timeline

YangKeao created this revision.May 18 2022, 3:23 AM
Herald added a project: Restricted Project. · View Herald Transcript
YangKeao requested review of this revision.May 18 2022, 3:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 18 2022, 3:23 AM
YangKeao updated this revision to Diff 430311.May 18 2022, 3:26 AM
YangKeao updated this revision to Diff 430334.May 18 2022, 5:07 AM

rebase to the master

YangKeao updated this revision to Diff 430337.May 18 2022, 5:10 AM
YangKeao updated this revision to Diff 430369.May 18 2022, 6:56 AM

Format codes

Meinersbur accepted this revision.May 27 2022, 8:38 AM

LGTM

Would you like me to commit for you?

polly/lib/Transform/MaximalStaticExpansion.cpp
521

[style] Unnecessary parens.

527–528

[style] No almost-always-auto.

Here it helps to see that MaximalStaticExpansionImpl will be released by RAII

This revision is now accepted and ready to land.May 27 2022, 8:38 AM
YangKeao updated this revision to Diff 432833.May 29 2022, 10:29 PM
YangKeao marked 2 inline comments as done.

Would you like me to commit for you?

@Meinersbur Sure! Thanks! 🍻

This revision was automatically updated to reflect the committed changes.

There were two compiler warnings I fixed before committing:

In file included from /home/meinersbur/src/llvm-project/polly/lib/Transform/MaximalStaticExpansion.cpp:14:
/home/meinersbur/src/llvm-project/polly/include/polly/MaximalStaticExpansion.h:14:9: warning: 'POLLY_MAXIMALSTATICEXPANSION_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]
#ifndef POLLY_MAXIMALSTATICEXPANSION_H
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/meinersbur/src/llvm-project/polly/include/polly/MaximalStaticExpansion.h:15:9: note: 'POLLY_MAXIMALSTATICEXPANSIO_H' is defined here; did you mean 'POLLY_MAXIMALSTATICEXPANSION_H'?
#define POLLY_MAXIMALSTATICEXPANSIO_H
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        POLLY_MAXIMALSTATICEXPANSION_H
/home/meinersbur/src/llvm-project/polly/lib/Transform/MaximalStaticExpansion.cpp:414:15: warning: field 'Dependences' will be initialized after field 'ORE' [-Wreorder-ctor]
      : S(S), Dependences(Dependences), ORE(ORE) {}
        ~~~~  ^~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~
        ORE(ORE) S(S)                   Dependences(Dependences)
2 warnings generated.