These tests demonstrate cases where the constant produced by folding
a floating point instruction should differ based on the denormal
handling mode set in function attributes.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
I'm not sure what is the right protocol for adding review comments to a long-submitted patch.
But, whilst thinking of adding float16 tests, I noticed 4 possible inconsistencies in float32 tests.
llvm/test/Transforms/InstSimplify/constant-fold-fp-denormal.ll | ||
---|---|---|
562 | Should #0 be #1? otherwise this test is identical to the previous test, including having the same attributes | |
569 | ||
576 | ||
583 |
Comment Actions
Yes, I remember spotting this as well. It seems I did include corrections for them in https://reviews.llvm.org/D129298 but that was ultimately abandoned.
Should #0 be #1? otherwise this test is identical to the previous test, including having the same attributes