Page MenuHomePhabricator

[libc++] Lets to_chars use header implementation.
ClosedPublic

Authored by Mordante on May 17 2022, 3:37 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG89818f2dc0b6: [libc++] Lets to_chars use header implementation.
Summary

This removes the duplicated code from the dylib. Instead the dylib will
call the new functions in the header. Since this code is unneeded it's
removed from the unstable ABI.

Depends on D125704

Diff Detail

Event Timeline

Mordante created this revision.May 17 2022, 3:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:37 AM
Herald added a subscriber: mgorny. · View Herald Transcript
Mordante requested review of this revision.May 17 2022, 3:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2022, 3:37 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Tue, May 31, 9:36 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/include/__config
119–120
libcxx/src/ryu/d2s.cpp
529 ↗(On Diff #429992)

To consider: If this increases our diff with "upstream" Ryu, it might be better to either #define __DIGIT_TABLE __itoa::__digits_base_10, or static constexpr auto& __DIGIT_TABLE = __itoa::__digits_base_10;.

This revision is now accepted and ready to land.Tue, May 31, 9:36 AM
Mordante marked 2 inline comments as done.Wed, Jun 1, 10:44 PM
Mordante added inline comments.
libcxx/src/ryu/d2s.cpp
529 ↗(On Diff #429992)

As mentioned in the live review, since the code is in the dylib we can use inline constexpr instead of static constexpr

Mordante updated this revision to Diff 433655.Wed, Jun 1, 10:47 PM
Mordante marked an inline comment as done.

Rebased and addresses review comments.

This revision was automatically updated to reflect the committed changes.