The /branch and /cherry-pick commands only work when an isssue has
a milestone, so give the user a helpful error message when they
try these commands on issue without a milestone.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
Looks good except for what I think is a typo and some suggestion for improving the readability and how things are connected with the workflow. Afterall, this is triggered by a comment, that produces another comment that we want to ignore or skip. Hm, maybe skip is better than ignore?
llvm/utils/git/github-automation.py | ||
---|---|---|
153–155 | <!--IGNORE--> seems like a special comment that gets parsed here: https://github.com/llvm/llvm-project/blob/7e5f75aa37801b9e4e9f0e3fb9f0358cbafb6f63/.github/workflows/issue-release-workflow.yml#L35. I suggest to create a dedicated function for this to make this more obvious where this gets ignored. Also I think the > before the {} placeholder was not intended, right? | |
164 |
llvm/utils/git/github-automation.py | ||
---|---|---|
153–155 |
The '>' character is to quote the original comment. |
LGTM now. Thank you for addressing the comments.
llvm/utils/git/github-automation.py | ||
---|---|---|
163 | Not sure if this was in here before but this is a great improvement in case the comment spanned more than one line! |
<!--IGNORE--> seems like a special comment that gets parsed here: https://github.com/llvm/llvm-project/blob/7e5f75aa37801b9e4e9f0e3fb9f0358cbafb6f63/.github/workflows/issue-release-workflow.yml#L35. I suggest to create a dedicated function for this to make this more obvious where this gets ignored. Also I think the > before the {} placeholder was not intended, right?