This is an archive of the discontinued LLVM Phabricator instance.

github: Add a helpful message for issues without milestones
ClosedPublic

Authored by tstellar on May 16 2022, 10:32 PM.

Details

Summary

The /branch and /cherry-pick commands only work when an isssue has
a milestone, so give the user a helpful error message when they
try these commands on issue without a milestone.

Diff Detail

Event Timeline

tstellar created this revision.May 16 2022, 10:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:32 PM
tstellar requested review of this revision.May 16 2022, 10:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 10:32 PM
thieta accepted this revision.Jul 5 2022, 11:20 AM

Lgtm

This revision is now accepted and ready to land.Jul 5 2022, 11:20 AM
kwk requested changes to this revision.Jul 6 2022, 9:07 AM
kwk added a subscriber: kwk.

Looks good except for what I think is a typo and some suggestion for improving the readability and how things are connected with the workflow. Afterall, this is triggered by a comment, that produces another comment that we want to ignore or skip. Hm, maybe skip is better than ignore?

llvm/utils/git/github-automation.py
153–155

<!--IGNORE--> seems like a special comment that gets parsed here: https://github.com/llvm/llvm-project/blob/7e5f75aa37801b9e4e9f0e3fb9f0358cbafb6f63/.github/workflows/issue-release-workflow.yml#L35. I suggest to create a dedicated function for this to make this more obvious where this gets ignored. Also I think the > before the {} placeholder was not intended, right?

164
This revision now requires changes to proceed.Jul 6 2022, 9:07 AM
tstellar updated this revision to Diff 443098.Jul 7 2022, 5:55 PM

Address review comments.

tstellar marked 2 inline comments as done.Jul 7 2022, 5:57 PM
tstellar added inline comments.
llvm/utils/git/github-automation.py
153–155

<!--IGNORE--> seems like a special comment that gets parsed here: https://github.com/llvm/llvm-project/blob/7e5f75aa37801b9e4e9f0e3fb9f0358cbafb6f63/.github/workflows/issue-release-workflow.yml#L35. I suggest to create a dedicated function for this to make this more obvious where this gets ignored. Also I think the > before the {} placeholder was not intended, right?

The '>' character is to quote the original comment.

kwk accepted this revision.Jul 11 2022, 3:28 AM

LGTM now. Thank you for addressing the comments.

llvm/utils/git/github-automation.py
163

Not sure if this was in here before but this is a great improvement in case the comment spanned more than one line!

This revision is now accepted and ready to land.Jul 11 2022, 3:28 AM
kwk removed a reviewer: kkleine.Jul 11 2022, 3:28 AM
This revision was landed with ongoing or failed builds.Jul 15 2022, 10:11 AM
This revision was automatically updated to reflect the committed changes.
tstellar marked an inline comment as done.