This is an archive of the discontinued LLVM Phabricator instance.

Differential D125736

[OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a typed pointer
ClosedPublic

Authored by aeubanks on May 16 2022, 5:51 PM.

Details

Reviewers
nikic
Group Reviewers
Restricted Project
Commits
rG470910c4ad8a: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a…
Summary

Followup to D125735 on the bitcode reader side.

Diff Detail

Unit TestsFailed

TimeTest
60,090 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,040 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,030 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
60,050 msx64 debian > libFuzzer.libFuzzer::out-of-process-fuzz.test
60,030 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

aeubanks created this revision.May 16 2022, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 5:51 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
aeubanks requested review of this revision.May 16 2022, 5:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 5:51 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aeubanks added a reviewer: Restricted Project.May 16 2022, 5:51 PM
Harbormaster completed remote builds in B164786: Diff 429911.May 16 2022, 6:23 PM
nikic accepted this revision.May 17 2022, 12:47 AM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.May 17 2022, 12:47 AM
This revision was landed with ongoing or failed builds.May 17 2022, 8:44 AM
Closed by commit rG470910c4ad8a: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a… (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG470910c4ad8a: [OpaquePtr][BitcodeReader] Explicitly turn off opaque pointers if we see a….

Revision Contents

PathSize
llvm/
lib/
Bitcode/
Reader/
2 lines

Diff 429911

llvm/lib/Bitcode/Reader/BitcodeReader.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,884 Lines • ▼ Show 20 Lines case bitc::TYPE_CODE_POINTER: { // POINTER: [pointee type] or
return error("Invalid pointer record"); return error("Invalid pointer record");
unsigned AddressSpace = 0; unsigned AddressSpace = 0;
if (Record.size() == 2) if (Record.size() == 2)
AddressSpace = Record[1]; AddressSpace = Record[1];
ResultTy = getTypeByID(Record[0]); ResultTy = getTypeByID(Record[0]);
if (!ResultTy || if (!ResultTy ||
!PointerType::isValidElementType(ResultTy)) !PointerType::isValidElementType(ResultTy))
return error("Invalid type"); return error("Invalid type");
if (LLVM_UNLIKELY(!Context.hasSetOpaquePointersValue()))
Context.setOpaquePointers(false);
ContainedIDs.push_back(Record[0]); ContainedIDs.push_back(Record[0]);
ResultTy = PointerType::get(ResultTy, AddressSpace); ResultTy = PointerType::get(ResultTy, AddressSpace);
break; break;
} }
case bitc::TYPE_CODE_OPAQUE_POINTER: { // OPAQUE_POINTER: [addrspace] case bitc::TYPE_CODE_OPAQUE_POINTER: { // OPAQUE_POINTER: [addrspace]
if (Record.size() != 1) if (Record.size() != 1)
return error("Invalid opaque pointer record"); return error("Invalid opaque pointer record");
if (LLVM_UNLIKELY(!Context.hasSetOpaquePointersValue())) { if (LLVM_UNLIKELY(!Context.hasSetOpaquePointersValue())) {
▲ Show 20 Lines • Show All 5,678 Lines • Show Last 20 Lines