[OpaquePtr][LLParser] Explicitly turn off opaque pointers if we see a star

[aeubanks]

Summary

If we turn on --opaque-pointers, tests with '*' would use opaque pointers.

Can't really test this without flipping the default value for --opaque-pointers.

[nikic]

LG. This seems like a good path towards wider default-enablement of opaque pointers without updating all the tests first.

llvm/lib/AsmParser/LLParser.cpp

70

For anyone else confused, this whole code only runs with !hasSetOpaquePointersValue(), so no need to check it here.

llvm/lib/AsmParser/LLParser.cpp

 
 static void setContextOpaquePointers(LLLexer &L, LLVMContext &C) {
   while (true) {
     lltok::Kind K = L.Lex();
     // LLLexer will set the opaque pointers option in LLVMContext if it sees an
     // explicit "ptr".
     if (K == lltok::star || K == lltok::Error || K == lltok::Eof ||
         isa_and_nonnull<PointerType>(L.getTyVal())) {
+      if (K == lltok::star)
+        C.setOpaquePointers(false);
       return;
     }
   }
 }
 
 /// Run: module ::= toplevelentity*
 bool LLParser::Run(bool UpgradeDebugInfo,
                    DataLayoutCallbackTy DataLayoutCallback) {