This is an archive of the discontinued LLVM Phabricator instance.

Differential D125659

[SelectionDAG] Make getNode which uses single element SDVTList pass SDNodeFlags.
ClosedPublic

Authored by fakepaper56 on May 15 2022, 9:41 PM.

Details

Reviewers
craig.topper
Commits
rG26a61ab6789f: [SelectionDAG] Make getNode which uses single element SDVTList pass SDNodeFlags.
Summary

The patch make users not need to know getNode with SDNodeFlags argument may not
pass its flags.

Diff Detail

Event Timeline

fakepaper56 created this revision.May 15 2022, 9:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 9:41 PM
Herald added subscribers: StephenFan, ecnelises, hiraditya. · View Herald Transcript
fakepaper56 requested review of this revision.May 15 2022, 9:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 9:41 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B164572: Diff 429603.May 15 2022, 10:27 PM
craig.topper accepted this revision.May 16 2022, 12:28 AM

LGTM

This revision is now accepted and ready to land.May 16 2022, 12:28 AM
This revision was landed with ongoing or failed builds.May 16 2022, 3:19 AM
Closed by commit rG26a61ab6789f: [SelectionDAG] Make getNode which uses single element SDVTList pass SDNodeFlags. (authored by fakepaper56). · Explain Why
This revision was automatically updated to reflect the committed changes.
fakepaper56 added a commit: rG26a61ab6789f: [SelectionDAG] Make getNode which uses single element SDVTList pass SDNodeFlags..

Revision Contents

PathSize
llvm/
lib/
CodeGen/
SelectionDAG/
2 lines

Diff 429668

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,907 Lines • ▼ Show 20 LinesSDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, SDVTList VTList,
if (Inserter) if (Inserter)
Flags = Inserter->getFlags(); Flags = Inserter->getFlags();
return getNode(Opcode, DL, VTList, Ops, Flags); return getNode(Opcode, DL, VTList, Ops, Flags);
} }
SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, SDVTList VTList, SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, SDVTList VTList,
ArrayRef<SDValue> Ops, const SDNodeFlags Flags) { ArrayRef<SDValue> Ops, const SDNodeFlags Flags) {
if (VTList.NumVTs == 1) if (VTList.NumVTs == 1)
return getNode(Opcode, DL, VTList.VTs[0], Ops); return getNode(Opcode, DL, VTList.VTs[0], Ops, Flags);
#ifndef NDEBUG #ifndef NDEBUG
for (auto &Op : Ops) for (auto &Op : Ops)
assert(Op.getOpcode() != ISD::DELETED_NODE && assert(Op.getOpcode() != ISD::DELETED_NODE &&
"Operand is DELETED_NODE!"); "Operand is DELETED_NODE!");
#endif #endif
switch (Opcode) { switch (Opcode) {
▲ Show 20 Lines • Show All 2,769 Lines • Show Last 20 Lines