Page MenuHomePhabricator

[libcxxabi] Copy headers into build location
ClosedPublic

Authored by phosek on Fri, May 13, 7:32 PM.

Details

Summary

Prior to D120727, the libcxx build was responsible for copying libcxxabi
headers into the right location, both in the build and install trees,
but now it's the responsibility of the libcxxabi build. While the build
already did the right thing for the install tree, it wouldn't copy
headers into the build tree, resulting in errors when trying to use the
just built toolchain as is the case in the runtimes build when building
compiler-rt runtimes.

Diff Detail

Event Timeline

phosek created this revision.Fri, May 13, 7:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, May 13, 7:32 PM
Herald added a subscriber: mgorny. · View Herald Transcript
phosek requested review of this revision.Fri, May 13, 7:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, May 13, 7:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
paulkirth accepted this revision.Fri, May 13, 8:46 PM

LGTM, given that the patch basically restores the code removed in D120727.

phosek accepted this revision.Fri, May 13, 8:49 PM
This revision is now accepted and ready to land.Fri, May 13, 8:49 PM
This revision was automatically updated to reflect the committed changes.